Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nutritional Information #22

Open
hschallh opened this issue Oct 5, 2017 · 4 comments
Open

Nutritional Information #22

hschallh opened this issue Oct 5, 2017 · 4 comments

Comments

@hschallh
Copy link

hschallh commented Oct 5, 2017

Add optional caloric / nutritional information. Thoughts:

  • Include ability to log calories, fat, carbs, and protein (any others?)
  • Where should nutritional information be displayed? (list/view)
  • Should calculate correctly with servings on view -s and when serving size is stipulated in add
@LuxMiranda
Copy link
Owner

LuxMiranda commented Oct 6, 2017

You actually bring up a good point here. We don't yet have serving information as info in each recipe... Before you'd be able to properly calculate nutritional information for so many servings, that would be pretty necessary. That would be implemented by #13 . You could still start working on it though while we take care of that. I might end up doing that this weekend.

Wild micro-managy opinions follow, please disregard if you dislike them or they seem scary:

As far as the information goes, I think that Calories, fat, carbs, and protein is a perfect set of nutritional data. I conjecture that most folks that are concerned with more than just calories and macro-nutrients will probably be using some other specialized software anyway. (Do speak up if you disagree!)

I think it should definitely be displayed when you view a recipe. An optimal place would probably be between the description and the directions, but I'd encourage you to experiment to see what feels most natural. :)

I think it would be cool to make adding the nutritional info a separate Brick interface that you can jump to from the main "Add" screen or pass a flag from the command line to only edit the nutritional info.

@LuxMiranda
Copy link
Owner

@hschallh #27 has implemented recipes containing serving information. Go crazy! :)

@hschallh
Copy link
Author

I think having it in "Add" is a good idea. I'll pull the changes and get started!

@LuxMiranda
Copy link
Owner

Yay! Good luck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants