Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Rush screen effect stays on screen after ending rush and breaks menus #35

Closed
CLGZFGFrankerZ123 opened this issue Feb 28, 2024 · 19 comments
Labels
bug Something isn't working

Comments

@CLGZFGFrankerZ123
Copy link

CLGZFGFrankerZ123 commented Feb 28, 2024

Issue Summary:

The wind effect at the top and bottom of the screen that appears when Rush is activated doesn't disappear when Rush is ended, including when using an All-Out Attack. Skill selection and Shuffle Time menus are entirely black screens aside from text, but are still functional. Item selection is mostly a black screen. Wind effect does not disappear until the results screen.

Update: The wind effect also does not disappear as it should when fast forwarding text. The effect should disappear when fast forward is cancelled, either manually or automatically when a choice box pops up. Note how in the last screenshot, the fast forward icon is not highlighted in blue.

P3RFix & Game Version Numbers:

P3RFix version 1.1.5
P3 Reload is Steam, current patch.

Log Files:

[2024-02-27 18:41:08.644] [P3RFix] [info] ----------
[2024-02-27 18:41:08.644] [P3RFix] [info] P3RFix v1.1.5 loaded.
[2024-02-27 18:41:08.644] [P3RFix] [info] ----------
[2024-02-27 18:41:08.644] [P3RFix] [info] Path to logfile: W:\SteamLibrary\steamapps\common\P3R\P3R\Binaries\Win64\P3RFix.log
[2024-02-27 18:41:08.644] [P3RFix] [info] ----------
[2024-02-27 18:41:08.644] [P3RFix] [info] Module Name: P3R.exe
[2024-02-27 18:41:08.644] [P3RFix] [info] Module Path: W:\SteamLibrary\steamapps\common\P3R\P3R\Binaries\Win64
[2024-02-27 18:41:08.644] [P3RFix] [info] Module Address: 0x140000000
[2024-02-27 18:41:08.644] [P3RFix] [info] Module Timestamp: 1704862230
[2024-02-27 18:41:08.644] [P3RFix] [info] ----------
[2024-02-27 18:41:08.645] [P3RFix] [info] Path to config file: W:\SteamLibrary\steamapps\common\P3R\P3R\Binaries\Win64\P3RFix.ini
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: iInjectionDelay: 1000ms
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: bCustomResolution: true
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: iCustomResX: 0
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: iCustomResY: 0
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: bSkipLogos: true
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: iSkipLogos: 2
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: bUncapMenuFPS: true
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: bPauseOnFocusLoss: false
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: bHUDFix: true
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: bAspectFix: true
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: bFOVFix: true
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: bScreenPercentage: false
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: fScreenPercentage: 100
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: bRenTexResMulti: true
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: fRenTexResUserMulti = 1
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: bAdjustFPSCap: false
[2024-02-27 18:41:08.646] [P3RFix] [info] Config Parse: fFramerateCap: 120
[2024-02-27 18:41:08.646] [P3RFix] [info] ----------
[2024-02-27 18:41:08.646] [P3RFix] [info] Custom Resolution: Desktop Width: 2560
[2024-02-27 18:41:08.646] [P3RFix] [info] Custom Resolution: Desktop Height: 1440
[2024-02-27 18:41:08.646] [P3RFix] [info] Custom Resolution: fAspectRatio: 1.7777778
[2024-02-27 18:41:08.646] [P3RFix] [info] Custom Resolution: fAspectMultiplier: 1
[2024-02-27 18:41:08.646] [P3RFix] [info] Custom Resolution: fHUDWidth: 2560
[2024-02-27 18:41:08.646] [P3RFix] [info] Custom Resolution: fHUDHeight: 1440
[2024-02-27 18:41:08.646] [P3RFix] [info] Custom Resolution: fHUDWidthOffset: 0
[2024-02-27 18:41:08.646] [P3RFix] [info] Custom Resolution: fHUDHeightOffset: 0
[2024-02-27 18:41:08.646] [P3RFix] [info] ----------
[2024-02-27 18:41:09.683] [P3RFix] [info] Caution Skip: Address is P3R.exe+14edd1a
[2024-02-27 18:41:09.683] [P3RFix] [info] Caution Skip: Skipped to network dialog.
[2024-02-27 18:41:09.744] [P3RFix] [info] Network Skip: Address is P3R.exe+14ee6e6
[2024-02-27 18:41:09.745] [P3RFix] [info] Network Skip: Dialog: Address is P3R.exe+11fd9e8
[2024-02-27 18:41:09.745] [P3RFix] [info] Network Skip: Skipped over network dialog.
[2024-02-27 18:41:09.794] [P3RFix] [info] Intro Skip: Address is P3R.exe+14ee6bb
[2024-02-27 18:41:09.794] [P3RFix] [info] Intro Skip: Skipped intro to title state 5.
[2024-02-27 18:41:10.187] [P3RFix] [info] Custom Resolution: Address is P3R.exe+140003f0
[2024-02-27 18:41:10.254] [P3RFix] [info] FOV: Address is P3R.exe+2f0fb2a
[2024-02-27 18:41:10.340] [P3RFix] [info] Aspect Ratio: Address is P3R.exe+2f0fb2f
[2024-02-27 18:41:10.360] [P3RFix] [info] Aspect Ratio Check: Address is P3R.exe+cb94f4
[2024-02-27 18:41:10.360] [P3RFix] [info] Aspect Ratio Check: Instruction patched.
[2024-02-27 18:41:10.376] [P3RFix] [info] HUD Constraints: Address is P3R.exe+ccbc6c
[2024-02-27 18:41:10.397] [P3RFix] [info] Fade Status: Address is P3R.exe+1050420
[2024-02-27 18:41:10.419] [P3RFix] [info] Fades: Address is P3R.exe+104e7dd
[2024-02-27 18:41:10.419] [P3RFix] [info] Fades: Function address is P3R.exe+ccff20
[2024-02-27 18:41:10.499] [P3RFix] [info] Screen Percentage: Address is P3R.exe+315957c
[2024-02-27 18:41:10.591] [P3RFix] [info] Render Texture 2D Resolution: Address is P3R.exe+347c1d0
[2024-02-27 18:41:10.609] [P3RFix] [info] RT_Capture: Address is P3R.exe+cab8f4
[2024-02-27 18:41:10.629] [P3RFix] [info] Menu FPS Cap: Address is P3R.exe+1069507
[2024-02-27 18:41:10.629] [P3RFix] [info] Menu FPS Cap: Patched instruction.
[2024-02-27 18:41:10.657] [P3RFix] [info] Window Focus: Address is P3R.exe+154a366
[2024-02-27 18:41:12.798] [P3RFix] [info] Render Texture 2D Resolution: fRenTexResMulti = 1.3333334
[2024-02-27 18:41:12.798] [P3RFix] [info] Render Texture 2D Resolution: Old render texture resolution = 1920x1080
[2024-02-27 18:41:12.798] [P3RFix] [info] Render Texture 2D Resolution: New render texture resolution = 2560x1440
[2024-02-27 18:41:12.799] [P3RFix] [info] Render Texture 2D Resolution: fRenTexResMulti = 1.3333334
[2024-02-27 18:41:12.799] [P3RFix] [info] Render Texture 2D Resolution: Old render texture resolution = 1920x1080
[2024-02-27 18:41:12.799] [P3RFix] [info] Render Texture 2D Resolution: New render texture resolution = 2560x1440
[2024-02-27 18:41:12.800] [P3RFix] [info] Render Texture 2D Resolution: fRenTexResMulti = 1.3333334
[2024-02-27 18:41:12.800] [P3RFix] [info] Render Texture 2D Resolution: Old render texture resolution = 1920x1080
[2024-02-27 18:41:12.800] [P3RFix] [info] Render Texture 2D Resolution: New render texture resolution = 2560x1440
[2024-02-27 18:41:12.801] [P3RFix] [info] Render Texture 2D Resolution: fRenTexResMulti = 1.3333334
[2024-02-27 18:41:12.801] [P3RFix] [info] Render Texture 2D Resolution: Old render texture resolution = 1920x1080
[2024-02-27 18:41:12.801] [P3RFix] [info] Render Texture 2D Resolution: New render texture resolution = 2560x1440
[2024-02-27 18:41:12.802] [P3RFix] [info] Render Texture 2D Resolution: fRenTexResMulti = 1.3333334
[2024-02-27 18:41:12.802] [P3RFix] [info] Render Texture 2D Resolution: Old render texture resolution = 1920x1080
[2024-02-27 18:41:12.802] [P3RFix] [info] Render Texture 2D Resolution: New render texture resolution = 2560x1440
[2024-02-27 18:41:14.821] [P3RFix] [info] Render Texture 2D Resolution: fRenTexResMulti = 1.3333334
[2024-02-27 18:41:14.821] [P3RFix] [info] Render Texture 2D Resolution: Old render texture resolution = 1920x1080
[2024-02-27 18:41:14.821] [P3RFix] [info] Render Texture 2D Resolution: New render texture resolution = 2560x1440
[2024-02-27 18:41:14.821] [P3RFix] [info] Render Texture 2D Resolution: fRenTexResMulti = 1.3333334
[2024-02-27 18:41:14.821] [P3RFix] [info] Render Texture 2D Resolution: Old render texture resolution = 1920x1080
[2024-02-27 18:41:14.821] [P3RFix] [info] Render Texture 2D Resolution: New render texture resolution = 2560x1440
[2024-02-27 18:41:47.374] [P3RFix] [info] Render Texture 2D Resolution: fRenTexResMulti = 1.3333334
[2024-02-27 18:41:47.374] [P3RFix] [info] Render Texture 2D Resolution: Old render texture resolution = 1024x1024
[2024-02-27 18:41:47.374] [P3RFix] [info] Render Texture 2D Resolution: New render texture resolution = 1365x1365

Reproduction:

Enter any battle and activate Rush. End Rush, then attempt to use any menu.

Or attempt to fast forward any dialogue.

20240227181658_1
20240227181702_1
20240227181725_1
20240227182942_1
20240227214559_1

@CLGZFGFrankerZ123 CLGZFGFrankerZ123 added the bug Something isn't working label Feb 28, 2024
@Lyall
Copy link
Owner

Lyall commented Feb 28, 2024

Can you try with "Fix HUD" set to disabled in P3RFix.ini?

@CLGZFGFrankerZ123
Copy link
Author

Disabling Fix HUD made no difference.

@Lyall
Copy link
Owner

Lyall commented Feb 28, 2024

Hmm, that's an odd one. The only things I could think of that would affect that, would be the HUD fix and maybe uncapping the framerate but you've tried with both disabled, so I'm not sure.

This may be a dumb question but, I take it this does not happen with P3RFix uninstalled/disabled? I quickly went in to Tartarus to try and replicate the issue but it's fine for me.

Here's a video of testing it on my end by just immediately rushing in a tartarus fight.
https://streamable.com/5fa85r

@CLGZFGFrankerZ123
Copy link
Author

CLGZFGFrankerZ123 commented Feb 28, 2024

The game worked fine for 100 hours before installing P3RFix. I'll update this post after I try uninstalling it.

Edit: The game works properly with P3RFix uninstalled.

@Lyall
Copy link
Owner

Lyall commented Feb 28, 2024

The game worked fine for 100 hours before installing P3RFix. I'll update this post after I try uninstalling it.

Edit: The game works properly with P3RFix uninstalled.

Okay that's good to confirm. So to try and find out what's causing it I'll need you to run through disabling some features then testing since I can't replicate the bug on my end. If you're up for that I would start by disabling both the intro skip and the uncap menu fps option in P3RFix.ini. After that if there's no improvement then we can try disabling more stuff.

@CLGZFGFrankerZ123
Copy link
Author

Disabling intro skip and uncap menu fps did not make a difference.

@Lyall
Copy link
Owner

Lyall commented Feb 28, 2024

🤔 That's a weird one. What about disabling everything? So basically every option is disabled apart from pause on focus loss since that's true by default.

@CLGZFGFrankerZ123
Copy link
Author

It seems to be related to pause on focus loss. I tried with everything set to false and nothing changed, but then setting pause on focus loss back to true fixed it.

@Lyall
Copy link
Owner

Lyall commented Feb 28, 2024

It seems to be related to pause on focus loss. I tried with everything set to false and nothing changed, but then setting pause on focus loss back to true fixed it.

Alright that's great that we've narrowed it down now. Can you try out this test build? It changes the way the pause on focus loss patch works.

P3RFix_v1.1.5_test_Steam.zip

@CLGZFGFrankerZ123
Copy link
Author

The bug is still present in the test build.

@Lyall
Copy link
Owner

Lyall commented Feb 28, 2024

The bug is still present in the test build.

And that's still with pause on focus loss set to "disabled"?

@CLGZFGFrankerZ123
Copy link
Author

The bug is still present in the test build.

And that's still with pause on focus loss set to "disabled"?

Correct.

@Lyall
Copy link
Owner

Lyall commented Feb 28, 2024

The bug is still present in the test build.

And that's still with pause on focus loss set to "disabled"?

Correct.

You're not using any other mods right? Just P3RFix?

@CLGZFGFrankerZ123
Copy link
Author

Also correct. Just P3RFix.

@Lyall
Copy link
Owner

Lyall commented Feb 28, 2024

Alright, well leave it with me for a bit then. At least we know how to fix your issue by disabling the tweak to pause on focus loss for now.

I'll have to see if I want to do this the windows way or continue trying to do it the unreal engine way.

Edit: Added it to the known issues bit for now until I can fix it.

@Lyall
Copy link
Owner

Lyall commented Feb 28, 2024

Okay, here's another test build. Let me know how this goes for you.

P3RFix_v1.1.5_test2_Steam.zip

@CLGZFGFrankerZ123
Copy link
Author

CLGZFGFrankerZ123 commented Feb 29, 2024

It is fixed, both in battle and in dialogue!

Edit: Oh no, tabbing out of the game keeps the cursor locked into the game window (or the center of the screen when pulling up a window ontop of the game), effectively disabling tabbing out entirely.
Correction: this only happens when the mouse controls the camera. Pulling up any menu or dialogue box, or entering combat is enough to get around this new issue.

@Lyall
Copy link
Owner

Lyall commented Feb 29, 2024

It is fixed, both in battle and in dialogue!

Edit: Oh no, tabbing out of the game keeps the cursor locked into the game window (or the center of the screen when pulling up a window ontop of the game), effectively disabling tabbing out entirely. Correction: this only happens when the mouse controls the camera. Pulling up any menu or dialogue box, or entering combat is enough to get around this new issue.

Hmm, since we can now have access to what the window focus state would be. It might be possible to block background input of the mouse when "unfocused".

@Lyall
Copy link
Owner

Lyall commented Mar 21, 2024

This is fixed in v1.1.7 and the known issue of the mouse being captured if alt+tabbing while not in a menu has been added to the list.

@Lyall Lyall closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants