Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload window in v5 disappears before all uploads are finished. #2129

Closed
sloniupl opened this issue Dec 29, 2023 · 7 comments · Fixed by #2140
Closed

Upload window in v5 disappears before all uploads are finished. #2129

sloniupl opened this issue Dec 29, 2023 · 7 comments · Fixed by #2140
Labels
bug Something isn't working

Comments

@sloniupl
Copy link

sloniupl commented Dec 29, 2023

Detailed description of the problem [REQUIRED]

Upload window in v5 disappears before all uploads are finished. Tested with 30 and more photos. Looks like up to 20 photos it is uploading correctly.
After it disapears looks like photos are still uploaded in the bacground, if you go to Job Logs and click on it every few seconds you can see new photos uploaded but you already exited the album.
If you get back to the album or refresh the website than the "upload" that you don't see is stopped and not all photos are uploaded.

To help me upload photos i enabled: skip_duplicates and use_job_queues but this didn't change the behavior.
Don't know if the issue is related to lychee being hosted behind nginx proxy manager reverse proxy but i have TRUSTED_PROXIES=* env enabled.

Steps to reproduce the issue

Steps to reproduce the behavior:

  1. Go to any album
  2. Click on upload photos
  3. Add around 50 photos for testing

Output of the diagnostics [REQUIRED]

(Settings => Diagnostics or https://example.com/Diagnostics or php artisan lychee:diagnostics)

    Diagnostics
    -----------
    Warning: Dropbox import not working. dropbox_key is empty.
    Info: Latest version of PHP is 8.3
    Warning: git (software) is not available.
    Foreign key: access_permissions.user_id     → users.id             : CASCADE
    Foreign key: albums.parent_id               → albums.id            : RESTRICT
    Foreign key: albums.id                      → base_albums.id       : RESTRICT
    Foreign key: albums.cover_id                → photos.id            : CASCADE
    Foreign key: base_albums.owner_id           → users.id             : RESTRICT
    Foreign key: jobs_history.owner_id          → users.id             : RESTRICT
    Foreign key: photos.album_id                → albums.id            : RESTRICT
    Foreign key: photos.owner_id                → users.id             : RESTRICT
    Foreign key: size_variants.photo_id         → photos.id            : RESTRICT
    Foreign key: sym_links.size_variant_id      → size_variants.id     : RESTRICT
    Foreign key: tag_albums.id                  → base_albums.id       : RESTRICT

    System Information
    ------------------
    Lychee Version (git):                    ?? (33354a2) -- Could not compare.
    DB Version:                              5.0.2
    
    composer install:                        --no-dev
    APP_ENV:                                 production
    APP_DEBUG:                               false
    APP_URL:                                 set
    
    System:                                  Linux
    PHP Version:                             8.2.7
    PHP User agent:                          Lychee/4 (https://lycheeorg.github.io/)
    Timezone:                                Europe/Warsaw
    Max uploaded file size:                  100M
    Max post size:                           100M
    Livewire chunk size:                     12.00 MB
    Max execution time:                      3600
    MySQL Version:                           11.2.2-MariaDB-1:11.2.2+maria~ubu2204
    
    exec() Available:                        yes
    Imagick Available:                       1
    Imagick Enabled:                         1
    Imagick Version:                         1691
    GD Version:                              2.3.3
    Number of foreign key:                   11 found.

    Config Information
    ------------------
    version:                                 050002
    check_for_updates:                       0
    sorting_photos_col:                      taken_at
    sorting_photos_order:                    ASC
    sorting_albums_col:                      max_taken_at
    sorting_albums_order:                    ASC
    imagick:                                 1
    skip_duplicates:                         1
    small_max_width:                         0
    small_max_height:                        360
    medium_max_width:                        1920
    medium_max_height:                       1080
    lang:                                    pl
    image_overlay_type:                      desc
    default_license:                         none
    compression_quality:                     90
    grants_full_photo_access:                1
    delete_imported:                         0
    mod_frame_enabled:                       1
    mod_frame_refresh:                       30
    thumb_2x:                                1
    small_2x:                                1
    medium_2x:                               1
    landing_page_enable:                     0
    site_owner:                              SloniuPl
    landing_title:                           SloniuPl
    landing_subtitle:                        Wesele Sylwi i Bartka
    sm_facebook_url:                         
    sm_flickr_url:                           
    sm_twitter_url:                          
    sm_instagram_url:                        
    sm_youtube_url:                          
    landing_background:                      dist/cat.webp
    site_title:                              Sylwia i Bartek
    footer_show_copyright:                   1
    site_copyright_begin:                    2023
    site_copyright_end:                      2023
    footer_additional_text:                  
    footer_show_social_media:                0
    search_public:                           0
    SL_enable:                               0
    SL_for_admin:                            0
    recent_age:                              1
    grants_download:                         0
    photos_wraparound:                       1
    map_display:                             0
    zip64:                                   1
    map_display_public:                      0
    map_provider:                            OpenStreetMap.org
    force_32bit_ids:                         0
    map_include_subalbums:                   0
    update_check_every_days:                 3
    has_exiftool:                            1
    share_button_visible:                    0
    import_via_symlink:                      0
    has_ffmpeg:                              1
    location_decoding:                       0
    location_decoding_timeout:               30
    location_show:                           0
    location_show_public:                    0
    rss_enable:                              0
    rss_recent_days:                         7
    rss_max_items:                           100
    prefer_available_xmp_metadata:           0
    editor_enabled:                          1
    lossless_optimization:                   0
    swipe_tolerance_x:                       150
    swipe_tolerance_y:                       250
    local_takestamp_video_formats:           .avi|.mov
    log_max_num_line:                        1000
    unlock_password_photos_with_url_param:   0
    nsfw_visible:                            1
    nsfw_blur:                               0
    nsfw_warning:                            0
    nsfw_warning_admin:                      0
    nsfw_banner_override:                    
    map_display_direction:                   1
    album_subtitle_type:                     oldstyle
    upload_processing_limit:                 4
    new_photos_notification:                 0
    legacy_id_redirection:                   1
    zip_deflate_level:                       6
    SA_enabled:                              1
    default_album_protection:                1
    album_decoration:                        layers
    album_decoration_orientation:            row
    allow_username_change:                   1
    auto_fix_orientation:                    1
    use_job_queues:                          1
    random_album_id:                         starred
    use_last_modified_date_when_no_exif_date: 0
    ffmpeg_path:                             /usr/bin/ffmpeg
    ffprobe_path:                            /usr/bin/ffprobe
    layout:                                  justified
    date_format_photo_thumb:                 M j, Y, g:i:s A e
    date_format_photo_overlay:               M j, Y, g:i:s A e
    date_format_sidebar_uploaded:            M j, Y, g:i:s A e
    date_format_sidebar_taken_at:            M j, Y, g:i:s A e
    date_format_hero_min_max:                F Y
    date_format_hero_created_at:             M j, Y, g:i:s A T
    date_format_album_thumb:                 M Y
    upload_chunk_size:                       0
    nsfw_banner_blur_backdrop:               0
    search_pagination_limit:                 1000
    search_minimum_length_required:          4
    photo_layout_justified_row_height:       320
    photo_layout_masonry_column_width:       300
    photo_layout_grid_column_width:          250
    photo_layout_square_column_width:        200
    photo_layout_gap:                        12
    display_thumb_album_overlay:             always
    display_thumb_photo_overlay:             hover

Browser and system

Chrome and Windows 11

@niker
Copy link

niker commented Dec 29, 2023

Same problem on 5.0.2, only files below about 90MB get uploaded if I stay on the page but the progress disappears after like 10% on each file and I need to refresh.
Tried to tinker with upload_chunk_size and use_job_queues with no effect.

I eventually "fixed" it by setting
LIVEWIRE_ENABLED=false
in my .env file, that seems to force the legacy 4.x UI and fixes the uploads completely even for large videos.

@sloniupl
Copy link
Author

Thanks, tested that and it didn't help at least for me.

@niker
Copy link

niker commented Dec 30, 2023

I just tested switching the UI style to new and then old again and I'm positive this works.
LIVEWIRE_ENABLED=false
In /conf/.env, I'm using a 5.0.2 docker container.
Doesn't even need a server restart, the moment I save the .env file and F5 the browser I get a switch.
Try CTRL+F5 in the browser just in case it's cached or you must be editing a different file.

@sloniupl
Copy link
Author

Tested again and i' not able to get it. The upside is that files bigger than 100MB are uploading (just uploaded over 400MB video).

@ildyria
Copy link
Member

ildyria commented Dec 30, 2023

use_job_queues : This setting will make the processing of the pictures (and creation of the thumbs) in the background instead of waiting for the creation to display 100%.

This is why once the upload is complete, you don't see them all, but they appear a bit later and this is why the job is being updated a bit later.

@sloniupl
Copy link
Author

sloniupl commented Jan 2, 2024

After disabling it back I still can't get the previous version of upload screen and i'm unable to upload more than 16-20 photos at a time.

@ildyria
Copy link
Member

ildyria commented Jan 29, 2024

I just uploaded 341 pictures without any break & problem. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants