Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 5.6 support #7

Closed
wants to merge 2 commits into from
Closed

Conversation

padarom
Copy link

@padarom padarom commented Jun 29, 2018

For reasons see #6

mledoze/countries no longer contains countries with empty regions, they are all using the new region Antarctic now. As such I removed \Countries::$REGION_NONE and added \Countries::$REGION_ANTARCTIC.

Also, the subregion Northern America was renamed to North America. I updated the tests to reflect that.

Both of these changes are compatibility breaking, so this should be a new major version.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 92.683% when pulling 80c826f on padarom:laravel56 into 3f7f388 on Lykegenes:master.

@padarom
Copy link
Author

padarom commented Jun 29, 2018

Build fails for PHP 5.6 and PHP 7.0

Laravel 5.6 upped the minimum version to PHP7.1 so I had to change the dev dependencies to reflect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants