Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with python3.10 #173

Open
tothedistance opened this issue May 28, 2022 · 7 comments
Open

Not compatible with python3.10 #173

tothedistance opened this issue May 28, 2022 · 7 comments
Assignees

Comments

@tothedistance
Copy link

ImportError: cannot import name 'Iterable' from 'collections'
as python3.10 changed it to collections.abc

@Lyken17
Copy link
Owner

Lyken17 commented May 30, 2022

Thanks for the pointer. Will push a if-else stament to fix.

@Lyken17 Lyken17 self-assigned this May 30, 2022
@gregorybchris
Copy link

@Lyken17 it looks like this is already changed in master branch! (in commit 439ca20d99792fb0bd46e98a2a2640a049bbca37) Do you plan to release a new version of this package to PyPI?

@Lyken17
Copy link
Owner

Lyken17 commented Jun 9, 2022

Oops. forget to update.

Just uploaded a new version to PyPi. Please check.

@tothedistance
Copy link
Author

thop history in pypi show the most recent revison dates back to may 5, 2020. And i create a new enviroment and install thop, the error is still there. am I missing something

@Lyken17
Copy link
Owner

Lyken17 commented Jun 10, 2022

That's caused by version number mismatch and 0.0.5 (version number I used git) is less than 0.0.31.

Just reuploaded and newer version should be avaliable on pypi .

@tothedistance
Copy link
Author

onnx does not support python3.10 yet. so new error occured in import. but i assume the problem of collections is solved.

@Lyken17
Copy link
Owner

Lyken17 commented Jun 12, 2022

Let me try to move onnx import to a deeper location and see whether it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants