Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support the newer zstd compression #19

Open
bobombolo opened this issue Mar 11, 2023 · 7 comments
Open

support the newer zstd compression #19

bobombolo opened this issue Mar 11, 2023 · 7 comments

Comments

@bobombolo
Copy link

i heard on the minetest forums that this library doesn't support the latest world sqlite format -- something to do with zstd compression?

@Lymkwi
Copy link
Owner

Lymkwi commented Mar 18, 2023

It's not entirely surprising that my library doesn't support zstd compression. I wrote it more than half a decade ago (it's bad Python, the kind you write when you haven't been coding for long), and that's about when I last opened the game as well.

Are people still using this? It could be worth re-opening good ol' MT for the lols and seeing if I can update my stuff easily to support newer versions.

@bobombolo
Copy link
Author

i would play with it and i know someone on the MT forum is trying to make a Minecraft to Minetest map converter in python...

@Lymkwi
Copy link
Owner

Lymkwi commented Mar 25, 2023

Update: I'm working on a fix for map versions >= 29, but currently python's zstd is unable to handle the mapblock data in minetest's files.. I'll work a bit more on it. Shouldn't be too hard.

@teverett
Copy link

@Lymkwi did you ever solve the zstd issue? I believe I am struggling with the same issue

@Lymkwi
Copy link
Owner

Lymkwi commented Dec 19, 2023

@Lymkwi did you ever solve the zstd issue? I believe I am struggling with the same issue

I think I managed to reproduce it but never figured anything useful out of the errors (or rather lack thereof) of Zstd. I had to dig in engine code to find the compression function and see if it did anything weird.. which it doesn't. Somehow it seems to be an incompatibility between python's Zstd and the library used by MT when both have default arguments.

Might try and give this a shot again, but I wouldn't expect a solution anytime soon

@teverett
Copy link

I did finally get it working. The problem seemed to be how I was using Redis. Once I had the right data, the decompression worked nicely.

@Lymkwi
Copy link
Owner

Lymkwi commented Dec 20, 2023

The problem seemed to be how I was using Redis.

In what sense exactly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants