Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c_iter isn't used #10

Closed
davidADSP opened this issue Dec 8, 2018 · 3 comments
Closed

c_iter isn't used #10

davidADSP opened this issue Dec 8, 2018 · 3 comments

Comments

@davidADSP
Copy link

c_iter is defined but not used in all of the WGAN files. What is the correct behaviour? i.e should the critic be optimised heavily initially or not?

Also, can you confirm that you use a learning rate parameter of 0.0002, regardless of whether RMSProp or Adam is used as the optimiser?

@LynnHo
Copy link
Owner

LynnHo commented Dec 8, 2018

@davidADSP Oh, it seems to be a bug, and n_critic here should be c_iter. Thanks!
https://github.com/LynnHo/DCGAN-LSGAN-WGAN-WGAN-GP-Tensorflow/blob/f9da7801a178b048b6212283f8e6ea7bf309da8b/train_mnist_wgan.py#L104

Besides, 0.0002 for the learning rate is the experience and different tasks should have different optimal learning rates, while I just use the same for convenience.

@davidADSP
Copy link
Author

OK thanks! - what learning rates did you use to generate the images on the README of this repo, for the various different tasks?

@LynnHo
Copy link
Owner

LynnHo commented Dec 9, 2018

@davidADSP All results are trained by 0.0002.

@LynnHo LynnHo closed this as completed Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants