New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the wild model scale error/typo #2

Closed

pablovela5620 opened this issue Mar 18, 2021 · 1 comment

pablovela5620 commented Mar 18, 2021

I believe this is a typo

HandTailor/model.py

Line 414 in 080818f

s = torch.sqrt((deltaj[0,0]**2 + deltaj[0,0]**2)/(1 - deltaj[0,2]**2))

where you're using the u coordinate twice instead of u-v according to this

it should be

s = torch.sqrt((deltaj[0,0]**2 + deltaj[0,1]**2)/(1 - deltaj[0,2]**2))

Owner

LyuJ1998 commented Mar 18, 2021

Hi, this is a typo. I have already fix this. Thank you for mention it!

LyuJ1998 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment