Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser crash (file attached) #13

Closed
GoogleCodeExporter opened this issue Jul 24, 2015 · 6 comments
Closed

Parser crash (file attached) #13

GoogleCodeExporter opened this issue Jul 24, 2015 · 6 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

Hello,

The attached SVG file crashes the SVGParser.

Here's the stacktrace:

08-21 19:12:59.707: E/ResourceImageItem(16638): Could not load image from 
resource
08-21 19:12:59.707: E/ResourceImageItem(16638): java.lang.NullPointerException
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVGParser.parsePath(SVGParser.java:3648)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVGParser.parseAttributesPath(SVGParser.java:1091)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVGParser.path(SVGParser.java:1078)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVGParser.startElement(SVGParser.java:629)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatParser.startElement(ExpatParser.java:143)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatParser.appendBytes(Native Method)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatParser.parseFragment(ExpatParser.java:513)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatParser.parseDocument(ExpatParser.java:474)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatReader.parse(ExpatReader.java:321)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatReader.parse(ExpatReader.java:279)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVGParser.parse(SVGParser.java:576)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVG.getFromResource(SVG.java:172)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
uk.ac.ucl.excites.collector.ui.picker.items.ResourceImageItem.setImage(ResourceI
mageItem.java:66)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
uk.ac.ucl.excites.collector.ui.picker.items.ImageItem.createView(ImageItem.java:
38)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
uk.ac.ucl.excites.collector.ui.picker.items.Item.getView(Item.java:36)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
uk.ac.ucl.excites.collector.ui.picker.PickerAdapter.getView(PickerAdapter.java:7
1)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.widget.AbsListView.obtainView(AbsListView.java:2465)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.widget.GridView.onMeasure(GridView.java:1030)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.View.measure(View.java:15326)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:4876)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1396)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.measureVertical(LinearLayout.java:681)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.onMeasure(LinearLayout.java:574)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.View.measure(View.java:15326)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:4876)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.widget.FrameLayout.onMeasure(FrameLayout.java:310)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.View.measure(View.java:15326)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:4876)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1396)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.measureVertical(LinearLayout.java:681)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.onMeasure(LinearLayout.java:574)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.View.measure(View.java:15326)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:4876)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.widget.FrameLayout.onMeasure(FrameLayout.java:310)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
com.android.internal.policy.impl.PhoneWindow$DecorView.onMeasure(PhoneWindow.jav
a:2423)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.View.measure(View.java:15326)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:1974)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:1217)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1390)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1113)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:4481)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.Choreographer$CallbackRecord.run(Choreographer.java:725)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.Choreographer.doCallbacks(Choreographer.java:555)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.Choreographer.doFrame(Choreographer.java:525)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:711)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.os.Handler.handleCallback(Handler.java:615)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.os.Handler.dispatchMessage(Handler.java:92)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.os.Looper.loop(Looper.java:137)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
android.app.ActivityThread.main(ActivityThread.java:4867)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
java.lang.reflect.Method.invokeNative(Native Method)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
java.lang.reflect.Method.invoke(Method.java:511)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1007)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:774)
08-21 19:12:59.707: E/ResourceImageItem(16638):     at 
dalvik.system.NativeStart.main(Native Method)
08-21 19:12:59.737: E/ResourceImageItem(16638): Could not load image from 
resource
08-21 19:12:59.737: E/ResourceImageItem(16638): java.lang.NullPointerException
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVGParser.parsePath(SVGParser.java:3648)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVGParser.parseAttributesPath(SVGParser.java:1091)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVGParser.path(SVGParser.java:1078)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVGParser.startElement(SVGParser.java:629)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatParser.startElement(ExpatParser.java:143)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatParser.appendBytes(Native Method)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatParser.parseFragment(ExpatParser.java:513)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatParser.parseDocument(ExpatParser.java:474)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatReader.parse(ExpatReader.java:321)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
org.apache.harmony.xml.ExpatReader.parse(ExpatReader.java:279)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVGParser.parse(SVGParser.java:576)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
com.caverock.androidsvg.SVG.getFromResource(SVG.java:172)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
uk.ac.ucl.excites.collector.ui.picker.items.ResourceImageItem.setImage(ResourceI
mageItem.java:66)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
uk.ac.ucl.excites.collector.ui.picker.items.ImageItem.createView(ImageItem.java:
38)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
uk.ac.ucl.excites.collector.ui.picker.items.Item.getView(Item.java:36)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
uk.ac.ucl.excites.collector.ui.picker.PickerAdapter.getView(PickerAdapter.java:7
1)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.AbsListView.obtainView(AbsListView.java:2465)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.GridView.makeAndAddView(GridView.java:1331)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.GridView.makeRow(GridView.java:331)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.GridView.fillDown(GridView.java:283)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.GridView.fillFromTop(GridView.java:407)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.GridView.layoutChildren(GridView.java:1219)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.AbsListView.onLayout(AbsListView.java:2300)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.View.layout(View.java:13891)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.ViewGroup.layout(ViewGroup.java:4424)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.setChildFrame(LinearLayout.java:1655)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.layoutVertical(LinearLayout.java:1513)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.onLayout(LinearLayout.java:1426)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.View.layout(View.java:13891)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.ViewGroup.layout(ViewGroup.java:4424)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.FrameLayout.onLayout(FrameLayout.java:448)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.View.layout(View.java:13891)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.ViewGroup.layout(ViewGroup.java:4424)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.setChildFrame(LinearLayout.java:1655)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.layoutVertical(LinearLayout.java:1513)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.LinearLayout.onLayout(LinearLayout.java:1426)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.View.layout(View.java:13891)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.ViewGroup.layout(ViewGroup.java:4424)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.widget.FrameLayout.onLayout(FrameLayout.java:448)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.View.layout(View.java:13891)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.ViewGroup.layout(ViewGroup.java:4424)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.ViewRootImpl.performLayout(ViewRootImpl.java:1992)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1813)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1113)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:4481)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.Choreographer$CallbackRecord.run(Choreographer.java:725)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.Choreographer.doCallbacks(Choreographer.java:555)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.Choreographer.doFrame(Choreographer.java:525)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:711)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.os.Handler.handleCallback(Handler.java:615)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.os.Handler.dispatchMessage(Handler.java:92)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.os.Looper.loop(Looper.java:137)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
android.app.ActivityThread.main(ActivityThread.java:4867)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
java.lang.reflect.Method.invokeNative(Native Method)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
java.lang.reflect.Method.invoke(Method.java:511)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1007)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:774)
08-21 19:12:59.737: E/ResourceImageItem(16638):     at 
dalvik.system.NativeStart.main(Native Method)

Original issue reported on code.google.com by matthias...@gmail.com on 21 Aug 2013 at 6:15

Attachments:
@GoogleCodeExporter
Copy link
Author

Original comment by paul.leb...@gmail.com on 21 Aug 2013 at 6:21

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author 

Fixed in revision 242.

Made path parser more permissive.  Was balking at paths with commas between 
extra coords. Ed. "L1,2,3,4" (vs "L1,2 3,4").   

This fix will be in the upcoming release 1.3.0.


Workaround for now: remove commas from between pairs of coords.  So for example 
in this file, change the path def to:

  "M18.773,952.36 0,971.14 31.047,1002.5 0,1033.6l18.773,18.773 31.047-31.048 ...
                 ^        ^             ^                      ^             ^

Thanks for the bug report!

Original comment by paul.leb...@gmail.com on 21 Aug 2013 at 7:07

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author 

Your welcome! Thanks for the lighting fast fix!

Original comment by matthias...@gmail.com on 21 Aug 2013 at 7:11

@GoogleCodeExporter
Copy link
Author 

Issue 27 has been merged into this issue.

Original comment by paul.leb...@gmail.com on 7 Jan 2014 at 3:59

@GoogleCodeExporter
Copy link
Author 

Issue 28 has been merged into this issue.

Original comment by paul.leb...@gmail.com on 14 Jan 2014 at 2:21

@GoogleCodeExporter
Copy link
Author 

This fix is available in the 1.2.1 release.

Original comment by paul.leb...@gmail.com on 31 Jan 2014 at 1:33

This was referenced Jul 24, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter