Debug regex for ImageRule

[loudmouth]

The regex for ImageRule was broken. It would take any ! as the start of an inline image even if there was no image present in the markdown text if there was a regular link later in the same string.

i.e. this was breaking and being rendered as an image: "Congratulations! Here is some text, head over to the Example site"

I've fixed the regex. You can test with the following string here

proper regex: !\[([^]]*)\]\(([^]]+)\)
proper regex with extra escapes for swift strings: !\\[([^]]*)\\]\\(([^]]+)\\)
test string:
"Congratulations! Here is some text, head over to the Example site or contact support.

a
"

[jvanzummeren]

I was testing your pull request and discovered that your regex was producing different capture groups causing the converting to ImageMarkDownItem to fail (and the unit tests were also failing).
Fixed the problem in this commit: 2f5b426

I'm going to write some unit tests on monday to cover the problems you discovered. Also added a non-greedy modifier to the regex to improve the result.

Instead of today, i'll make a new Markymark version on monday.

Kind regards,

Jim

[loudmouth]

@jimvanzummeren I've discovered a very strange bug here that I can't understand. Basically, with markymark, if there is any non-linebreak character after the closing parenthesis ) for the ImageRule (i.e. )C is an example), then the Markdown converter will omit the TextAttachement that would normally be inserted into the NSAttributedString

Any ideas what may be going on?

Stepping through with the debugger, it looks like MarkyMark is still correctly identifying the markdown image with the regex...i think something else may be going on.

[loudmouth]

Some more info on this: it looks like by the time the parseMarkdown(:) method returns, the relevant ImageMarkdownItem is stripped from the returned array or [MarkdownItem]