Add SPM

[SMillerDev]

Gonna build packages for SPM and make the iOS department pay for it.

Make PHP developers great again

[simdani]

#98

[simdani]

@SMillerDev your build is failing because of UIKit imports, will you fix it? :)

[SMillerDev]

I might

[SMillerDev]

You clearly have a higher interest in it then beating your colleagues though. You might be better off making your own pull request. You could be the hero that fixes this for all users of Marky-Mark.

[lvnkmn]

Couldn't (really) wait for this to be merged, it turned out to work just fine for me. Nice one Sean!

[SMillerDev]

@lvnkmn are you saying this implementation is correct and my tests are just wrong?

[lvnkmn]

Not trying to offend your tests here. It works for what I need it to do, that's all.

[SMillerDev]

I'm not at all offended, just disappointed in my google skills 😄

[simdani]

It works well if you import UIKit in missing files :)

[SMillerDev]

Remaining failure seems to be an issue with iOS 13 more then SPM. @M2Mobi/ios any ideas?

[lvnkmn]

I have been pointing to @SMillerDev 's repo because of this for quite a bit now. Any news on when this can be merged (and if needed completed)?

[lvnkmn]

@Basca, @ThijsBouma This branch and PR works for me in swift package manager, however there's a couple of code changes that I don't think are appropriate:

1. Changes in podspec should not be needed for this
2. Commented out code in package.swift

Aside from that, some build settings have been changed, but have not resulted in travis tests actually succeeding.

What I'll do:

• I'll create a new pull request, using the changes that make sense.
• I'll close this PR as soon as that one is up.

What I'd like to know from you:
To what extend are you relying on the travis checks passing. Is local build and passing tests good enough? if that's the case we might be able to release this soon.

[SMillerDev]

Aside from that, some build settings have been changed, but have not resulted in travis tests actually succeeding.

Afaik this was an iOS 13/Xcode 11 issue. If you can make a pull request to fix travis with Xcode 11 I can clean up this review a bit.

[lvnkmn]

Closed in favor of #101