feat(react-i18n): add dutch plural (#89)

BedrockStreaming · Jun 19, 2021 · 714620a · 714620a
1 parent 8f65044
commit 714620a
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 10 deletions.
diff --git a/packages/react-i18n/README.md b/packages/react-i18n/README.md
@@ -216,10 +216,11 @@ This is the configuration of plural form for keys:
 
 | language | zero    | singular | general plural | first plural | second plural | third plural |
 | -------- | ------- | -------- | -------------- | ------------ | ------------- | ------------ |
-| FR       | `one`   | `one`    | `other`        | `other`      | -             | -            |
 | EN       | `other` | `one`    | `other`        | `other`      | -             | -            |
-| HU       | `one`   | `one`    | `other`        | `one`        | -             | -            |
+| FR       | `one`   | `one`    | `other`        | `other`      | -             | -            |
 | HR       | `many`  | `one`    | `other`        | `one`        | `few`         | `many`       |
+| HU       | `one`   | `one`    | `other`        | `one`        | -             | -            |
+| NL       | `other` | `one`    | `other`        | `other`      | -             | -            |
 
 The variable used in translation template string has to be `%(number)d`, and is automatically provided by the translate function.
 

diff --git a/packages/react-i18n/src/utils/__tests__/i18n.utils.spec.js b/packages/react-i18n/src/utils/__tests__/i18n.utils.spec.js
@@ -89,6 +89,17 @@ describe('i18n translate function', () => {
       expect(t('foo.bar', undefined, 1, true)).toBe('first plural');
       expect(t('foo.bar', undefined, 2, true)).toBe('general plural');
     });
+
+    it('should pluralize in dutch', () => {
+      const lang = {
+        foo: { bar: { one: 'foo bar!', other: 'foos bars!!!' } },
+        _i18n: { lang: 'nl' },
+      };
+      const t = translate(lang);
+      expect(t('foo.bar', undefined, 0, true)).toBe('foos bars!!!');
+      expect(t('foo.bar', undefined, 1, true)).toBe('foo bar!');
+      expect(t('foo.bar', undefined, 2, true)).toBe('foos bars!!!');
+    });
   });
 
   describe('with number interpolation', () => {

diff --git a/packages/react-i18n/src/utils/i18n.utils.js b/packages/react-i18n/src/utils/i18n.utils.js
@@ -3,15 +3,8 @@ import { sprintf } from 'sprintf-js';
 import { interpolateHTMLTags } from './html.utils';
 
 const pluralizeFunctions = {
-  en: number => (number === 0 || number > 1 ? 'other' : 'one'),
+  en: number => (number === 1 ? 'one' : 'other'),
   fr: number => (number > 1 ? 'other' : 'one'),
-  hu: (number, general) => {
-    if (!general) {
-      return 'one';
-    }
-
-    return number > 1 ? 'other' : 'one';
-  },
   hr: (number, general) => {
     // General plural
     if (general) {
@@ -34,6 +27,14 @@ const pluralizeFunctions = {
 
     return '';
   },
+  hu: (number, general) => {
+    if (!general) {
+      return 'one';
+    }
+
+    return number > 1 ? 'other' : 'one';
+  },
+  nl: number => (number === 1 ? 'one' : 'other'),
 };
 
 export const translate = (lang, i18nNames = {}, errorCallback = _.noop, parseHTML = false) => {