Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to display local document #3

Closed
MatthewMerritt opened this issue Sep 28, 2022 · 3 comments
Closed

Ability to display local document #3

MatthewMerritt opened this issue Sep 28, 2022 · 3 comments

Comments

@MatthewMerritt
Copy link

Your Welcome-Sheet looks awesome and works very well. I was wondering if you had any desire to add the ability to either display a document in a row or allow the button to open a local resource? My thought is for linking a local license file etc. I have an app that I would like to use your Welcome-Sheet, but the app has a requirement for working without any network/internet access and I want to have the ability to display a license from here.

@MAJKFL
Copy link
Owner

MAJKFL commented Oct 4, 2022

Hey, thanks for your kind words and suggestions! I've just added new branch with with two additional actions available for optional buttons: closures and custom views presented on top of Welcome Sheet. You set them as parameters during WelcomeSheetPage initialisation, just like you did with urls. I would suggest passing pdf view with your license to optionalButtonView: parameter when you create your page. After user taps the optional button it will be shown on screen.

WelcomeSheetPage(title: "Hello in my app!", rows: [
   // Rows
], optionalButtonTitle: "Terms and Conditions...", optionalButtonView: { DocumentView() })

I would love to hear your feedback and any new ideas. If everything works I will merge and make a release from it 🙂

@MatthewMerritt
Copy link
Author

Hi! Yes this work exactly how I envisioned it! Thank you for integrating my idea. Sorry it took so long to get back to you I went out of town for a weekend concert...

I will see if I can come up with other ideas/use cases and pass them on.

Thanks,
Matt.

@MAJKFL
Copy link
Owner

MAJKFL commented Feb 6, 2023

Added with v1.2.0

@MAJKFL MAJKFL closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants