This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
Add bsx_bios.rom options #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated readme and mostly mirrored comments in the script to fix typos and grammar slightly. :)
Realized new tab for download link is better, changed that, and added some improved formatting over previous 2 change.
|
I need time to look at this. May need to move your repo to our standard one
on Archive.org
…On Thu, Oct 15, 2020, 1:09 PM birdybro ***@***.***> wrote:
Untested as of now, but basically will add the BSX_BIOS and a good
structure for use. Default will be the BS-X project's English+NoDRM, with
folders for other options.
------------------------------
You can view, comment on, or merge this pull request online at:
#7
Commit Summary
- Readme updates
- Fix download link
- Further fixes and updates to Readme.md
- update bios-getter.sh for bsx_bios
File Changes
- *M* README.md
<https://github.com/MAME-GETTER/MiSTer_BIOS_SCRIPTS/pull/7/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(28)
- *M* bios-getter.sh
<https://github.com/MAME-GETTER/MiSTer_BIOS_SCRIPTS/pull/7/files#diff-9ab003f7bf9c89c394310d9b85fc29351a5c6212b866019e3144d42eb1cdb3d8>
(54)
- *M* update_bios-getter.sh
<https://github.com/MAME-GETTER/MiSTer_BIOS_SCRIPTS/pull/7/files#diff-e558346484ba63ebb208a096a677af4e5598bd59107e07959c795ba908d99735>
(8)
Patch Links:
- https://github.com/MAME-GETTER/MiSTer_BIOS_SCRIPTS/pull/7.patch
- https://github.com/MAME-GETTER/MiSTer_BIOS_SCRIPTS/pull/7.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APKJU6M7PIGEA3JI5HOWY5DSK4UDJANCNFSM4SSIK7GA>
.
|
|
Yup, is more of a proposal of how to do it, hopefully to save you time developing it yourself. I might test out the roms when I get home and see how they all work. The ones with DRM might not be worth using, for instance. |
|
Yeah tested at home, doesn't work, but I will submit this as draft on the main one, since I forgot that this repo was deprecated. |
|
Thanks @birdybro , I added it to the script right now. Your code was of good help. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested as of now, but basically will add the BSX_BIOS and a good structure for use. Default will be the BS-X project's English+NoDRM, with folders for other options.
Ignore the readme changes, I goofed on branches from other PR :P