Fix modifying an immutable variable during iteration--needs "is rw" #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefth
force-pushed
the
master
branch
2 times, most recently
from
3528926
to
5e94dfe
Compare
added 2 commits
October 24, 2017 18:55
MongoDB shouldn't change Log::Async's settings (or rely on them), so instead of using the logger singleton, it should create a logger instance and use only that. This fixes issue MARTIMM#29.
Fixes: Cannot assign to a readonly variable ($socket) or a value in block at /home/user/rakudo/share/perl6/site/sources/4F88D22071E3E320D8AAB5083BFC265C51014181 (MongoDB::Server) line 301
|
Its funny that it works for such a long time not passing this piece of code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Cannot assign to a readonly variable ($socket) or a value
in block at /home/user/rakudo/share/perl6/site/sources/4F88D22071E3E320D8AAB5083BFC265C51014181 (MongoDB::Server) line 301