Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Caching in the GitHub workflow #777

Open
utkarshg6 opened this issue Mar 13, 2024 · 0 comments
Open

Improve Caching in the GitHub workflow #777

utkarshg6 opened this issue Mar 13, 2024 · 0 comments
Assignees
Projects

Comments

@utkarshg6
Copy link

utkarshg6 commented Mar 13, 2024

It turns out that while caching the cargo files in the workflow, we are using the key: ${{ runner.os }}-cargo to uniquely identify and restore the cache.

This has cache invalidation issues, as it doesn't take into account changes in dependencies. To solve it we can introduce the hash of Cargo.lock to uniquely identify the cache based on the lockfile.

Here's a better alternative: key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}

@utkarshg6 utkarshg6 created this issue from a note in MASQNode (New) Mar 13, 2024
@utkarshg6 utkarshg6 self-assigned this Mar 13, 2024
@utkarshg6 utkarshg6 moved this from New to Development In Progress in MASQNode Mar 13, 2024
@utkarshg6 utkarshg6 linked a pull request Mar 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 Development In Progress
MASQNode
  
Development In Progress
Development

Successfully merging a pull request may close this issue.

2 participants