Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Marble reflections should update at higher frame rates #220

Open
1 task done
McMasterGold opened this issue Jun 2, 2024 · 3 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@McMasterGold
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Version

Beta 1.17

OS

Windows 11

Description

The real-time marble reflections update at a distinctly lower frame rate than the native one, and the problem becomes more severe when playing at lower frame rates. For example I am playing at 60 FPS, and it looks like the reflections are updating at 10 FPS. A tearing artifact can also be observed in the reflection.

The last build to not exhibit this issue was 1.14, while all builds from 1.15 and newer have it.

2024-06-02.20-43-04_new.mp4

Log File

No response

Steps to reproduce

No response

Expected Behavior

No response

Actual Behavior

No response

Reproduction frequency

No response

Additional Information

No response

@McMasterGold McMasterGold added the bug Something isn't working label Jun 2, 2024
@RandomityGuy
Copy link
Contributor

This is an intentional decision to improve framerate, instead of updating all the faces at once, only two of them are updated each frame.
See:


You can bring back the old behavior by commenting this line and compiling it
#define MB_CUBEMAP_FAST

@RandomityGuy RandomityGuy added enhancement New feature or request and removed bug Something isn't working labels Jun 2, 2024
@RandomityGuy RandomityGuy changed the title [BUG] Marble reflections update at a low frame rate Marble reflections update at a low frame rate Jun 2, 2024
@RandomityGuy RandomityGuy changed the title Marble reflections update at a low frame rate [REQUEST] Marble reflections should update at higher frame rates Jun 2, 2024
@McMasterGold
Copy link
Author

Appreciate the response! Sadly I have very little experience with compiling builds (and have mostly failed in the past) so I'm not quite sure how I could do this. Is there any chance that it could be added as a graphics setting in the future?

@RandomityGuy
Copy link
Contributor

Yes, that is the plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants