Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relevance of plots_1d.histstep #10

Closed
MBravoS opened this issue Apr 12, 2019 · 1 comment
Closed

Relevance of plots_1d.histstep #10

MBravoS opened this issue Apr 12, 2019 · 1 comment
Labels
question Further information is requested

Comments

@MBravoS
Copy link
Owner

MBravoS commented Apr 12, 2019

plots_1d.hist() changed from an interpolating line, drawn between the histogram points (using pyplot.plot()), to a step plot, flat across the width of each bin (using pyplot.step()). With that change it sees to me that plots_1d.histstep() has become superseded by plots_1d.hist(). I haven't removed it yet, but if agreed it should be done in the next version.

@MBravoS MBravoS added the question Further information is requested label Apr 12, 2019
@MBravoS MBravoS added this to To Do in Modifications to current code via automation Apr 12, 2019
@MBravoS
Copy link
Owner Author

MBravoS commented Apr 18, 2019

While currently plots_1d.hist() cover step plots, it does not produce filled steps and/or bars, so there is still a place for plots_1d.histstep(). It may be better to rename the latter though.

@MBravoS MBravoS closed this as completed Apr 18, 2019
Modifications to current code automation moved this from To Do to Done Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

1 participant