Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with tuple-specified linestyles #17

Closed
MBravoS opened this issue May 6, 2019 · 2 comments
Closed

Bug with tuple-specified linestyles #17

MBravoS opened this issue May 6, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@MBravoS
Copy link
Owner

MBravoS commented May 6, 2019

base_funcs.dict_splicer() breaks when it receives a tuple specifying the linestyle of a plot. We should add a test for data type when linestyle is given as a key in plot_par, and ensure that it gets passed correctly (wrapping it in a list works fine).

@MBravoS MBravoS added the bug Something isn't working label May 6, 2019
@MBravoS MBravoS added this to To Do in Modifications to current code via automation May 6, 2019
@MBravoS MBravoS self-assigned this May 6, 2019
@AstroRobin
Copy link
Collaborator

This also has further-reaching implications for any color being given as a tuple (e.g. (r,g,b,a)).
To fix this, we can check the first element of any tuple given to dict_splicer() if it is purely a 'string' OR the first element is explicitly numeric, then it should be treated as a single value rather than a set of values for multiple lines.

@MBravoS
Copy link
Owner Author

MBravoS commented Nov 29, 2019

Solve as of version 0.4.1.2.

@MBravoS MBravoS closed this as completed Nov 29, 2019
Modifications to current code automation moved this from To Do to Done Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants