Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in use of linear/log scale units in histograms #18

Closed
MBravoS opened this issue Jun 24, 2019 · 1 comment
Closed

Inconsistency in use of linear/log scale units in histograms #18

MBravoS opened this issue Jun 24, 2019 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@MBravoS
Copy link
Owner

MBravoS commented Jun 24, 2019

If bin_type is either 'width' or 'edges' and xlog or ylog are True, bins must be in log-scale units, but xlim/ylim remains in linear units, which may not be the desired behaviour.

@MBravoS MBravoS added the question Further information is requested label Jun 24, 2019
@MBravoS MBravoS added this to To Do in Modifications to current code via automation Jun 24, 2019
@MBravoS MBravoS self-assigned this Jun 24, 2019
@AstroRobin
Copy link
Collaborator

I think we should leave xlim and ylim to be left in linear units if xlog or ylog are True. The limits are inherently related to the data and as the data is being given in linear units, so too should the limits. You can then think that if one logs an axis, the widths/edges should also be given in log space as we are dealing with logarithmic bins, however, the data remains linear.

This seems the most consistent way to handle logged axis.

Modifications to current code automation moved this from To Do to Done Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

2 participants