Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming of hist_type="smooth" in splt.hist() #32

Closed
AstroRobin opened this issue Feb 11, 2020 · 1 comment
Closed

Renaming of hist_type="smooth" in splt.hist() #32

AstroRobin opened this issue Feb 11, 2020 · 1 comment
Assignees
@MBravoS
Labels
improvement Suggestion for existing code
Projects
Modifications to current code

Comments

@AstroRobin
Copy link
Collaborator

As we do not actually perform a smoothing interpolation of data points when hist_type='smooth', it is probably not appropriate for it to be called "smooth". As performing an interpolation is dangerous territory, we should instead rename "smooth" --> "line".
@AstroRobin AstroRobin added the improvement Suggestion for existing code label Feb 11, 2020
@AstroRobin AstroRobin added this to To Do in Modifications to current code via automation Feb 11, 2020
@MBravoS
Copy link
Owner

MBravoS commented Apr 8, 2020

Implemented in version 0.4.6.8.

@MBravoS MBravoS closed this as completed Apr 8, 2020
Modifications to current code automation moved this from To Do to Done Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBravoS MBravoS

Labels
improvement Suggestion for existing code
Projects
Modifications to current code
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AstroRobin @MBravoS