Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features in matplotlib v3.4 and splotch #60

Closed
MBravoS opened this issue May 27, 2021 · 1 comment
Closed

New features in matplotlib v3.4 and splotch #60

MBravoS opened this issue May 27, 2021 · 1 comment
Assignees
Labels
improvement Suggestion for existing code

Comments

@MBravoS
Copy link
Owner

MBravoS commented May 27, 2021

I just noticed that v3.4 has been released (3.4.2 at time of writing), and having a quick look I noticed at least one new feature that could be useful for splotch: the new matplotlib.pyplot.stairs function. This could be useful for plots_1d.hist when passing hist_type='step', as currently we have to add one extra data point to get the same behaviour from matplotlib.pyplot.step. We should still keep the current method for backward compatibility, but could be something to change un the future. Also worth having a more detailed look at everything new with 3.4, might be more things we could use there.

@AstroRobin
Copy link
Collaborator

Switched to using plt.stairs() for plotting hist_types='step' and 'stepfilled' in devel@e55c572. Functionality is exactly what we needed and negates the need for the custom step_filler functions, these can be removed from base_func.py in a later version.

Modifications to current code automation moved this from To Do to Done Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Suggestion for existing code
Development

No branches or pull requests

2 participants