Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to arguments after pressing F5 with a build are ignored #158

Closed
djfooks opened this issue Jun 27, 2023 · 1 comment
Closed

Changes to arguments after pressing F5 with a build are ignored #158

djfooks opened this issue Jun 27, 2023 · 1 comment
Labels

Comments

@djfooks
Copy link

djfooks commented Jun 27, 2023

To reproduce

  1. Make a change to a cpp
  2. Hit F5 and chose to build
  3. Change an argument while the build is ongoing

Observe that the application is not started with the changed arguments. Stopping and starting again gets the new arguments.

@Irame
Copy link
Collaborator

Irame commented Sep 7, 2023

This happens because we only update the project configuration on the "ProjectBeforeRun" event (see code).

The solution would be to also update the configuration every time the tree is changed. I don't know if that would bring some unwanted side effects, but I think it would be fine.

This would also fix #65. (Except for cases where only the project configuration, target platform, or launch profile changes.)

@Irame Irame added the bug label Sep 7, 2023
@Irame Irame closed this as completed in d8cc3f7 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants