Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing when left open #92

Open
Ariikitty opened this issue Jul 17, 2023 · 7 comments
Open

Crashing when left open #92

Ariikitty opened this issue Jul 17, 2023 · 7 comments

Comments

@Ariikitty
Copy link

I have found an issue on Windows where when the application is left open, whether this be in the dock or just minimised, the application seems to hang and then crash.

It seems like after a little while, the application stops pulling information from the friends list and then trying to select anything causes a crash to happen. I have found this happening after about 12 - 36 hours of having the application open but it may happen sooner, I just haven't properly timed it.

@HotaruBlaze
Copy link
Contributor

Do you get any kind of error popup?

@MCMi460
Copy link
Owner

MCMi460 commented Jul 20, 2023

I do remember this being a problem a while back, but I thought that we fixed it. It's likely that it's somehow timing out when connecting to Nintendo, and when clicking a button on the menu bar, it tries to fetch from Nintendo using a dead session. I don't remember much, but if I were to guess, this happens most consistently when the app is subjected to trying to live through sleep mode?

@Ariikitty
Copy link
Author

Ariikitty commented Sep 20, 2023

I'm extremely late to these replies, to which I apologies.

Do you get any kind of error popup?

None, the crash doesn't happen till I restore the app from being minimized but even before restoring the app it's not posting anything to discord.

I do remember this being a problem a while back, but I thought that we fixed it. It's likely that it's somehow timing out when connecting to Nintendo, and when clicking a button on the menu bar, it tries to fetch from Nintendo using a dead session. I don't remember much, but if I were to guess, this happens most consistently when the app is subjected to trying to live through sleep mode?

It could be, going to try turning off sleep mode and leave my computer idle and see if I get the same result

@Ariikitty
Copy link
Author

Okay I have done more testing. I tried two tests where I have left my PC on and not in sleep mode (I can tell it hasn't gone into sleep mode cause a) I disabled it and b) I left an auto-clicker on cookie clicker for the duration of a day).

I have found that it only crashes if it's left open while Discord has been closed. I know there's an error message when it can't connect to discord if the application is opened before Discord is but there's nothing to say there's any issue with Discord being closed while the application is still running. It's also not till you try to restore the application from the system tray does it actually crash but it also won't update the discord status when you reopen Discord after a few hours

Leaving the program and Discord open all day does mean the application runs properly (at the cost of notifications being sent your mobile being inconsistent but that's a Discord issue)

@HotaruBlaze
Copy link
Contributor

I'm wondering how old your version is, although your initial issue is made just over a week after v1.3.8, it makes me wonder if using the latest version would resolve this, as retry code was added to the discord part: db08d6c and version details is still stuck in the development branch


I also have a development build that uses the latest development branch here that has an unrelated fix if you wanted to give this one a shot: https://github.com/HotaruBlaze/NSO-RPC/releases/tag/getVersion-Rewrite-build

@Ariikitty
Copy link
Author

I was wondering if I am a build behind but I couldn't find a version number from within the application so it may be worth checking it out, thank you

@HotaruBlaze
Copy link
Contributor

You're able to see where the version would be displayed here #96, Under the NSO-RPC name at the top left red square

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants