Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to make item compostable #56

Closed
KlemenDEV opened this issue Sep 7, 2020 · 9 comments
Closed

Option to make item compostable #56

KlemenDEV opened this issue Sep 7, 2020 · 9 comments
Labels
new feature New feature or request stale Stale issue

Comments

@KlemenDEV
Copy link
Contributor

New checkbox on item/food mod element to make the item compostable.

Adopted from https://mcreator.net/tracker/issue/64611

@KlemenDEV KlemenDEV added good first issue Good for new contributors to start working on new feature New feature or request labels Sep 7, 2020
@TheGoldenCreeper
Copy link

Instead of checkbox, how about new mod element type with item selection and chance to add layer. Also, a procedure trigger for when item is composted.

@KlemenDEV
Copy link
Contributor Author

That would be option too, although I don't want too many elements to be in MCreator. But if things you mentioned are possible, then why not.

@ZacSharp
Copy link

then why not.

In my opinion because it prevents you from combining them, so elements should only be used if the implementation makes it something different anyway (e.g. a different base class for that type of item)

@KlemenDEV KlemenDEV removed the good first issue Good for new contributors to start working on label Oct 11, 2020
@Defeatomizer
Copy link
Collaborator

Defeatomizer commented Oct 21, 2020

This feature is likely impossible.
All compostable items are registered via ComposterBlock and the method used to register them is private 😔

@KlemenDEV
Copy link
Contributor Author

KlemenDEV commented Oct 21, 2020

You just posted MC code, this is illegal.

I removed it from your comment for your own good.

Also learn about https://docs.oracle.com/javase/tutorial/reflect/

@Defeatomizer
Copy link
Collaborator

Defeatomizer commented Oct 21, 2020

(Thanx.)
Then it's fine.
I also removed comment change history too.

@stale
Copy link

stale bot commented Nov 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issue label Nov 20, 2020
@stale stale bot closed this as completed Nov 27, 2020
@LexShadow
Copy link

Has this been added or forgotten about as I can't seem to find this anywhere, or a work around for it?

@Defeatomizer
Copy link
Collaborator

#2479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request stale Stale issue
Projects
None yet
Development

No branches or pull requests

5 participants