Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner pattern mod element #3741

Closed
wants to merge 23 commits into from
Closed

Conversation

Max094Reikeb
Copy link
Collaborator

@Max094Reikeb Max094Reikeb commented Apr 2, 2023

This PR adds a new Banner Pattern mod element.

  • GUI
  • Icons
  • Template code for 1.18.2
  • Template code for 1.19.2
  • Template code for 1.19.4
  • In-app tips
  • Tests

@Max094Reikeb Max094Reikeb marked this pull request as draft April 2, 2023 14:24
@Max094Reikeb Max094Reikeb added the new feature New feature or request label Apr 2, 2023
@Max094Reikeb
Copy link
Collaborator Author

@Defeatomizer could you please translate English help tips into Russian?

@Atten007
Copy link

Atten007 commented Apr 2, 2023

@Max094Reikeb how can I translate the strings in this PR into German?

@Max094Reikeb
Copy link
Collaborator Author

@Max094Reikeb how can I translate the strings in this PR into German?

Go to my MCreator fork, and make a PR.

@Defeatomizer
Copy link
Collaborator

@Max094Reikeb how can I translate the strings in this PR into German?

You can't, our Crowdin profile is the place eligible for submitting translations.

@Max094Reikeb
Copy link
Collaborator Author

@Max094Reikeb how can I translate the strings in this PR into German?

You can't, our Crowdin profile is the place eligible for submitting translations.

He's talking about in-app tips

@stale
Copy link

stale bot commented Apr 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Do not remove this label manually, it should be removed by the bot when new activity occurs.

@stale stale bot added the stale Stale issue label Apr 25, 2023
@Max094Reikeb Max094Reikeb removed the stale Stale issue label Apr 25, 2023
@KlemenDEV
Copy link
Contributor

This PR is per-definition stale so please do not remove the label. PR is not complete and not being worked on.

Also from CONTRIBUTING.md:

If a contributor opens multiple new PRs without finishing old ones, we may assume the older PRs are no longer in their interest and close them, so other contributors and maintainers don't spend too much time reviewing PRs that will likely not get merged down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request stale Stale issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants