Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly deprecate readframes in libdcd #3930

Open
hmacdope opened this issue Nov 21, 2022 · 0 comments
Open

Possibly deprecate readframes in libdcd #3930

hmacdope opened this issue Nov 21, 2022 · 0 comments
Assignees
@hmacdope
Labels
Component-lib CZI-performance performance track of CZIEOSS4 grant deprecation Deprecated functionality to give advance warning for API changes.
Milestone
Release 3.0

Comments

@hmacdope
Copy link
Member

libdcd.readframes is a helper method to get timeseries-like behaviour from a DCD file. This is implemented at a very low level and no other reader seems to have an equivalent.

While I havn't benchmarked it (I imagine it is faster than the implementation in ReaderBase) it may be better to homogenise the implementation of timeseries in ReaderBase

Discussion in #3888 suggested deprecating it for 3.0
@hmacdope hmacdope added the CZI-performance performance track of CZIEOSS4 grant label Nov 21, 2022
@hmacdope hmacdope added this to the Release 3.0 milestone Nov 21, 2022
@hmacdope hmacdope self-assigned this Nov 21, 2022
@hmacdope hmacdope mentioned this issue Nov 21, 2022
Merged
4 tasks
@orbeckst orbeckst added the deprecation Deprecated functionality to give advance warning for API changes. label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmacdope hmacdope

Labels
Component-lib CZI-performance performance track of CZIEOSS4 grant deprecation Deprecated functionality to give advance warning for API changes.
Projects
CZI Performance track
Status: In Progress
Milestone
Release 3.0
Development

No branches or pull requests
2 participants
@orbeckst @hmacdope