Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move linting out of main gh action and don't make it run on merge #3985

Closed
IAlibay opened this issue Jan 4, 2023 · 1 comment
Closed

Move linting out of main gh action and don't make it run on merge #3985

IAlibay opened this issue Jan 4, 2023 · 1 comment
Labels
Continuous Integration

Comments

@IAlibay
Copy link
Member

IAlibay commented Jan 4, 2023

Expected behavior

When merging everything should be green if it's been approved.

Actual behavior

We quite often end up with a red badge because darker fails on merge. We should prevent that by moving darker out of the core action file into a separate linter one and just have them run in PRs not on merge to develop.
@IAlibay
Copy link
Member Author

IAlibay commented Mar 30, 2023

Should be fixed now.

@IAlibay IAlibay closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Continuous Integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orbeckst @IAlibay