Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table support? #15

Closed
ibhagwan opened this issue Dec 15, 2021 · 5 comments
Closed

Table support? #15

ibhagwan opened this issue Dec 15, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@ibhagwan
Copy link

ibhagwan commented Dec 15, 2021

First, great job on this and ty for taking ownership on mardown in neovim treesitter :-)

Are tables supported? I'm using treesitter to auto-generate vimdoc for my plugin from the README, I used to do with https://github.com/ikatyang/tree-sitter-markdown which recognized the below as table, this seems not to be the case here.

Are tables supported?

screenshot-1639535526

For reference, here's how it's parsed with the ikatyang:
screenshot-1639536128

@MDeiml
Copy link
Collaborator

MDeiml commented Dec 15, 2021

Tables are part of Github flavored markdown which is an extension of the CommonMark spec. I plan to add support for Github flavored markdown including tables, but so far haven't gotten around to it.

@MDeiml MDeiml added the enhancement New feature or request label Dec 15, 2021
@ibhagwan
Copy link
Author

Tysm, looking forward to it!

@ibhagwan
Copy link
Author

FYI, I updaed my fork of babelfish.nvim to work against your new parser, code is ugly as hell with a couple of hacks to support tables and other minor adjustments (TBH, the original code wasn't all that great to begin with) but it does work, and it does produce a fantastic result for my plugin's vimdoc, in case you wanna check it out:

README
vimdoc

@MDeiml
Copy link
Collaborator

MDeiml commented Dec 23, 2021

That looks great. I hope I will get to tables soon so the official repo for babelfish can use this parser. But I think I won't get too much done over Christmas

@MDeiml
Copy link
Collaborator

MDeiml commented Jul 27, 2022

Should work with the newest commit 🎉

@MDeiml MDeiml closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants