Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix log(free_e) in FreeEOS #189

Closed
aarondotter opened this issue Feb 23, 2021 · 4 comments
Closed

fix log(free_e) in FreeEOS #189

aarondotter opened this issue Feb 23, 2021 · 4 comments
Assignees
@aarondotter
Labels
eos Equation of state module release-blocker Things that should be fixed before the next release

Comments

@aarondotter
Copy link
Collaborator

mesa/eos/eosFreeEOS_builder/src/free_eos_table.f90

Line 166 in 3ab6b0a

result(i_lnfree_e)= log(xmu3)

The value reported in the table should be log10(free_e) not log(free_e).
@jschwab jschwab added the eos Equation of state module label Feb 23, 2021
@jschwab
Copy link
Collaborator

jschwab commented Feb 23, 2021

Yep. I agree that the simple fix is log(xmu3) -> log10(xmu3).

@aarondotter aarondotter self-assigned this Feb 23, 2021
@jschwab
Copy link
Collaborator

jschwab commented Feb 23, 2021 •
edited

I think the FreeEOS builder should compile again as of 9e711e6. Let me know if you have any issues.

@jschwab jschwab added the release-blocker Things that should be fixed before the next release label Mar 10, 2021
@aarondotter
Copy link
Collaborator Author

Fixed in a9f64f1

@evbauer evbauer mentioned this issue Jun 5, 2023
Closed
@evbauer
Copy link
Contributor

evbauer commented Jun 14, 2023

This was actually fixed up a bit more in 44283b2, so I'm just coming back here to leave that note on this issue before pointing to it in the known bugs page on the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarondotter aarondotter

Labels
eos Equation of state module release-blocker Things that should be fixed before the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jschwab @aarondotter @evbauer