Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move gaspari_cohn and calc_geodist_exact #158

Closed
mathause opened this issue Jun 10, 2022 · 2 comments · Fixed by #183
Closed

move gaspari_cohn and calc_geodist_exact #158

mathause opened this issue Jun 10, 2022 · 2 comments · Fixed by #183
Labels
good first issue Good for newcomers
Milestone

Comments

@mathause
Copy link
Member

mathause commented Jun 10, 2022

gaspari_cohn and calc_geodist_exact are in the file load_constant_files.py:

def gaspari_cohn(r):

def calc_geodist_exact(lon, lat):

This is the wrong place for the two functions and they should be moved to a better home. I don't have a super strong opinion where they need to go - probably mesmer/core/computation.py.

@mathause mathause added the good first issue Good for newcomers label Jun 10, 2022
@mathause
Copy link
Member Author

Don't forget to change the imports. Including the ones in the tests:

from mesmer.io import (

This was referenced Jun 10, 2022
@mathause
Copy link
Member Author

Or mesmer/core/spatial.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant