Switching to modern and modular precision declaration #42
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
MFC is filled with lines like this:
MFC/src/simulation/m_hypoelastic.f90
Lines 30 to 32 in a39962c
where the precision is declared via
kind(0d0)
.We also have a ton of this
MFC/src/simulation/m_riemann_solvers.fpp
Lines 547 to 556 in a39962c
where inline constants have precision declared in a "hard-coded" way.
What is better is declaring a separate constant that we can change as needed, like this
example, though there are many others.
A fix for this issue would remove all cases of
0d0
andkind(0d0)
and replace them with a constant declared in thecommon/
directory. I think this is a suitable task for @anshgupta1234 .I realize one can force precision via compiler variables, but I believe we should avoid this because there is an established language standard.
The text was updated successfully, but these errors were encountered: