Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDG_CACHE_HOME dir for storing log files #27

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

AnshumanNeon
Copy link
Contributor

#23
by the suggestion as refereneced above. I have added the enhancement of storing the log files in XDG_CACHE_HOME dir instead of the config dir itself.
By my research, the XDG spec doesn't clearly mention where the log files should be stored but it XDG_CACHE_HOME seems a good choice for this.

@yorukot
Copy link
Owner

yorukot commented Apr 9, 2024

oh I just update it to $XDG_DATA_HOME
May i ask why use $XDG_CACHE_HOME not $XDG_DATA_HOME

@yorukot
Copy link
Owner

yorukot commented Apr 9, 2024

oh i got it #23

@yorukot yorukot merged commit 16f73ae into yorukot:main Apr 9, 2024
@yorukot
Copy link
Owner

yorukot commented Apr 9, 2024

Thank for your pull request!

@getawaywithrmdir
Copy link

Just a heads-up, and this isn't urgent, but XDG_STATE_HOME is where logs should go--XDG_CACHE_HOME should be reserved for items you can safely delete knowing that the application can recreate them with no lost data, which is not the case for logs/history, and XDG_DATA_HOME is more likely to include stuff you want to sync across computers (Spec is here: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html.)

I think you are using rkoesters/xdg for basedir, and it doesn't appear they've added support for XDG_STATE_HOME yet, so I submitted a ticket there (rkoesters/xdg#15).

I'm loving this app! :)

@yorukot
Copy link
Owner

yorukot commented Apr 26, 2024

@getawaywithrmdir
Thanks for your suggestion!
Would you like to open a new issue about this?

@getawaywithrmdir
Copy link

Oh sure :). Upstream could update tomorrow, or never, so...one sec...

@getawaywithrmdir
Copy link

One sec...2 days later...I got distracted 😅.

Created: #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants