Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional origin to settings.py #63

Merged
merged 1 commit into from Dec 3, 2021
Merged

Add additional origin to settings.py #63

merged 1 commit into from Dec 3, 2021

Conversation

tvaroglu
Copy link
Collaborator

@tvaroglu tvaroglu commented Dec 3, 2021

  • Changes Implemented:

    • Add additional origin to settings.py to test newest front-end build via mars buildpack
    • Shorten conditionals in views.py (remove unnecessary else statements)

  • Quality Control Checklist:

    • >= 20% test coverage
    • Postman collection updated (if any changes to endpoints)
    • Last Commit passes CircleCI build
    • ReadMe updated if any changes to JSON Contracts

@tvaroglu tvaroglu added bug Something isn't working Refactor labels Dec 3, 2021
@justincanthony justincanthony merged commit f0f2b6b into main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justincanthony justincanthony justincanthony approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tvaroglu @justincanthony