Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ensembles into subclasses of IRSystemBase #11

Open
Witiko opened this issue Mar 20, 2023 · 0 comments
Open

Make ensembles into subclasses of IRSystemBase #11

Witiko opened this issue Mar 20, 2023 · 0 comments
Assignees
@MarekToma
Labels
enhancement New feature or request

Comments

@Witiko
Copy link
Member

Witiko commented Mar 20, 2023

Since #6, we've had ensembles available in the pv211_utils.ensembles module as functions. It seems more useful to treat ensembles as systems, i.e. let's move ensembles.py to system/ensembles.py and make each function into a subclass of IRSystemBase? See also a related comment from the review of #8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarekToma MarekToma

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Witiko @MarekToma