CakePHP 2.x upgrade to 3.x

[rhaist]

As announced by the CakePHP Team with the latest 2.x release[1] they will now focus on the 3.x release and feature cycle.

I tested the provided 2to3 upgrade tool today[1] and it seems to do work for the current 2.4 branch. As this would be a big change it has to be prepared, tested and coordinated by the MISP project maintainers and not by a PR.

The 3.x upgrade would probably help in the ongoing test coverage challenges (REF: #98) and allows/simplifies upgrading some other dependencies like bootstrap.

[1] https://github.com/cakephp/cakephp/releases/tag/2.10.0
[2] https://book.cakephp.org/3.0/en/upgrade-tool.html

[rhaist]

I ran bin/cake upgrade all ../MISP/app on a fork.

You can have a look at my branch over at:
https://github.com/SleuthKid/MISP/tree/cakephp-upgrade-3.x

[adulau]

Thank you for looking into this.

There will be a major release (and maybe some additional smaller releases later) soon of MISP to include the current objects branch. So it's foreseen but not before this major release.

Quickly looking into your branch, I'm wondering about such changes which mangle the code:

rhaist@7700476#diff-6026820ed6cbb17b5c9eb8a4c9df3c13R2345
rhaist@7700476#diff-6026820ed6cbb17b5c9eb8a4c9df3c13R2640

Maybe the conversion script needs to be reviewed?

If you want to test it, a PR could be interesting to see if Travis succeed with such automatic conversion
and if the basic API test works.

Thank you.

[Rafiot]

in the todo list: making sure a user running git pull after the upgrade doesn't run into issues (not only new installs have to be working)

[adulau]

@Rafiot Indeed very good point. Upgrade is a significant part of our user base.

[rhaist]

@adulau you are right. The upgrade tool parser does not seem to recognize that the "use" keyword is in a string variable. I will try to solve this upstream. I will look into the parsing errors and fix them manually and prepare a PR of the branch. I do not expect it to just work :)

In some other matter, the usage of phpfmt with cakephp profile or some other formatter would ease transitions in the future. CIRCL and MISP most probably qualify for phpstorm educational licensing[1].

[1] https://www.jetbrains.com/phpstorm/buy/#edition=discounts

[adulau]

@SleuthKid Which coding style do you use PSR2 or PHPCS? Not sure if there is a consensus on this. Especially if you want to diff on the long-run the whole project. @iglocska any recommendation?

[rhaist]

@adulau as I am not experienced in PHP programming I can not tell you which standard is most widely adopted. php ../phpcbf.phar -p -v app seems to fix a lot of indentation stuff but generates trailing whitespace in some corner cases. phpfmt sadly is now closed source but can be used from sublime3 as plugin.

[rhaist]

@adulau http://cs.sensiolabs.org/ does the best job in my fmt tests.

[rhaist]

Any updated plans on this. This is over 2 years now and CakePHP is close to moving to version 4.x while MISP still uses an old 2.x version. As most of the MISP core functionality is dependent on CakePHP I see a ticking time bomb here.

Upstream reference: https://bakery.cakephp.org/2017/06/23/upcoming-cakephp-roadmap.html

[iglocska]

It is on our roadmap and we're working on it. Announcements coming at hack.lu/misp summit.