Bug: When attributes are fetched using pagination pages can be empty or not full when items are skipped

[Benni0]

Expected behavior

When artifacts are fetched and enough attributes are available for the selected time, each page should be full except the last one.
This behavior is also expected when some attributes are skipped due enforceWarninglist or excludeDecayed.

Actual behavior

The amount of specified items for the specific page are fetched from the database and in the for loop each attribute which should be filtered is skipped. So the amount of returned attributes may be lower as the requested page size while matching attributes may exist on the next page.

Steps to reproduce

Fetch attributes using the REST API and use one of the filter, if there are some attributes which are skipped on one of the pages, the affected page has not as much attributes as requested.

Version

2.4.172

Operating System

CentOS

Operating System version

8

PHP version

7.4.30

Browser

No response

Browser version

No response

Relevant log output

No response

Extra attachments

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[iglocska]

The current behaviour is intentional as certain elements are removed in the post-processing. Basically we pass back a header that signals whether there is more data to fetch (based on the intrnal fetch, so before the post-processing fires) so relying on that would be best. Looping would potentially be a massive performance overhead.

With that said, if you could reimplement the support for the looping to be an optional feature that needs to be passed in a parameter (such as ensurePageLimit or something to that effect) then we could merge it.