Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment/Type attribute error in openioc.py #237

Closed
kahliya opened this issue Jun 12, 2018 · 0 comments
Closed

Comment/Type attribute error in openioc.py #237

kahliya opened this issue Jun 12, 2018 · 0 comments
Assignees

Comments

@kahliya
Copy link

kahliya commented Jun 12, 2018

'PortItem/remoteIP|PortItem/remotePort': {'comment': 'ip-dst|port'}

I believe the line above should be 'type': ip-dst|port instead of comment.

The code requires a 'type' attribute to be existing to parse the MISP json format.
But with this line, there will be a missing 'type' attribute when this format is found.

A KeyError will be raised.

Edit:
This is about the openioc.py in pymisp/tools

@kahliya kahliya changed the title Comment/Type attribute error? Comment/Type attribute error in openioc.py Jun 12, 2018
@Rafiot Rafiot self-assigned this Jun 12, 2018
@Rafiot Rafiot closed this as completed in fd36594 Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants