cal_plot()

[MahdiSafarpour]

When I run cal_plot() even on your toy data, I get two warning messages:

1: Ignoring unknown aesthetics: ymin, ymax
2: Removed 2 rows containing missing values (geom_bar).

Is there any solution for this issue?

[vikjam]

Seems like 1: Ignoring unknown aesthetics: ymin, ymax comes from the following line:

runway/R/cal_plots.R

Line 46 in e9e7492

ggplot2::geom_point(ggplot2::aes(x = bin_pred, y = bin_prob, ymin = ll, ymax = ul),

I don't think runway needs to use ymin and ymax in ggplot2::geom_point.

The second warning 2: Removed 2 rows containing missing values (geom_bar) comes from:

runway/R/cal_plots.R

Line 72 in e9e7492

ggplot2::scale_x_continuous(limits = c(0, 1), breaks = seq(0, 1, by = 0.1)) +

The ggplot2 team doesn't seem to be concerned about this warning when using ggplot2::scale_x_continuous with ggplot2::geom_histogram. I think runway could do without the limits argument in the aforementioned line.

[kdpsingh]

Thank you for noting these issues. We will be making several updates to the runway package in the next ~3 weeks to enhance the functionality and correct some bugs. We will plan to fix this issue.

I'm going to leave this issue open for now until we institute a fix.