Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curate PCA primitive hyperparameters #190

Closed
AlexanderGeiger opened this issue Aug 28, 2019 · 0 comments · Fixed by #191
Closed

Curate PCA primitive hyperparameters #190

AlexanderGeiger opened this issue Aug 28, 2019 · 0 comments · Fixed by #191
Assignees
@AlexanderGeiger
Labels
approved The issue is approved and someone can start working on it primitive improvement An improvement over an existing primitive
Milestone
0.2.1

Comments

@AlexanderGeiger
Copy link
Contributor

Description

In the sklearn.decomposition.PCA primitive, we are missing hyperparameters. Most importantly, n_components is missing, which allows to define the number of components to keep.

See here for all available hyperparameters.
@AlexanderGeiger AlexanderGeiger mentioned this issue Sep 3, 2019
Merged
@csala csala closed this as completed in #191 Sep 4, 2019
@csala csala added approved The issue is approved and someone can start working on it primitive improvement An improvement over an existing primitive labels Sep 4, 2019
@csala csala added this to the 0.2.1 milestone Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderGeiger AlexanderGeiger

Labels
approved The issue is approved and someone can start working on it primitive improvement An improvement over an existing primitive
Projects
None yet
Milestone
0.2.1
Development

Successfully merging a pull request may close this issue.

Curate PCA primitive hyperparameters AlexanderGeiger/MLPrimitives
2 participants
@csala @AlexanderGeiger