Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show React version #73

Open
taneliang opened this issue Jul 20, 2020 · 2 comments
Open

Show React version #73

taneliang opened this issue Jul 20, 2020 · 2 comments
Labels
importance: 2 - should have This should be implemented, but we will still have a working product if we don't phase: 2 - iteration Iterations on our MVP urgency: 4 - no urgency We have an indefinite amount of time to complete this work type: implementation A task that primarily involves bashing code

Comments

@taneliang
Copy link
Member

taneliang commented Jul 20, 2020

From Brian's 17 July email and doc:

Show lane labels and React version in the UI somewhere

@taneliang taneliang added phase: 2 - iteration Iterations on our MVP urgency: 4 - no urgency We have an indefinite amount of time to complete this importance: 2 - should have This should be implemented, but we will still have a working product if we don't work type: implementation A task that primarily involves bashing code labels Jul 20, 2020
@kartikcho
Copy link
Member

Hey @bvaughn, what do you think about keeping lane labels in the tooltip (as it is right now) instead of drawing labels at the start of a lane?

It will take up some valuable space on the left when we port it to Devtools. Adding labels might also make the Devtools UI look too 'packed' in my opinion.

I think the current tooltip does a good job of showing lane information. If we still want to put emphasis on the lane info, we can try moving it to the top of the tooltip or make the font bold.

Screenshot of the current tooltip:
image

@bvaughn
Copy link

bvaughn commented Aug 13, 2020

Good call. It's probably fine to keep the labels in the tooltip for now– particularly since we don't have anything meaningful to show for them (other than the number). 😄

@kartikcho kartikcho changed the title Show lane labels and React version Show React version Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
importance: 2 - should have This should be implemented, but we will still have a working product if we don't phase: 2 - iteration Iterations on our MVP urgency: 4 - no urgency We have an indefinite amount of time to complete this work type: implementation A task that primarily involves bashing code
Projects
No open projects
Development

No branches or pull requests

3 participants