Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication issues #13

Closed
mwittig opened this issue Jun 20, 2016 · 4 comments
Closed

Authentication issues #13

mwittig opened this issue Jun 20, 2016 · 4 comments

Comments

@mwittig
Copy link
Contributor

mwittig commented Jun 20, 2016

I have some concerns about commit 6be1c90

  1. Shouldn't authentication be optional to work with older versions of the z-way?!
  2. defaults for userId and password doesn't make much sense to me unless admin / "" (empty password) is a kind of factory default.

See also https://forum.pimatic.org/topic/1906/z-way-problem-with-0-9

@MMore
Copy link
Owner

MMore commented Jun 25, 2016

Hi,

  1. In my opinion it is better to force authentication for reasons of security.
  2. I agree with that, but I am not sure what the factory default of z-way is currently. @thexperiments?

@MMore MMore closed this as completed Dec 9, 2016
@mwittig
Copy link
Contributor Author

mwittig commented Dec 9, 2016

What's the conclusion on this?

@MMore
Copy link
Owner

MMore commented Dec 9, 2016

My first point stays the same. According 2nd: I am using pimatic with a local user and localhost. So I don't need credentials there and those config options must be optional.

@mwittig
Copy link
Contributor Author

mwittig commented Dec 9, 2016

Thanks for the clarification. To make those config options must be optional the default values need to be replaced with required: false, or leave it as is if the z-way API accepts the default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants