Create asset return 406

[Popesites]

Have been working on this issue for hours, cannot create asset using asset() resource.

Here is example query:

const id = this.themeId;

const query = {
  asset: {
    key: "snippets/test.liquid",
    value: "Content"
  }
};

const asset = await this.shopify.asset.create(id, query); // throws 406 Not Acceptable error

By the way I notice 2 small errors on asset create test...

1. Using the asset 'update' fixin instead of the 'create' fixin
2. Using the res fixin data instead of the req - basically an invalid request on the test itself?

[lpinca]

I don't see the error.

https://shopify.dev/docs/admin-api/rest/reference/online-store/asset#update-2020-01

Shopify-api-node/test/asset.test.js

Lines 62 to 71 in f91e090

	it('creates an asset', () => {
	const input = fixtures.req.create;
	const output = fixtures.res.create;
	scope.put('/admin/themes/828155753/assets.json', input).reply(200, output);
	return shopify.asset
	.create(828155753, input.asset)
	.then((data) => expect(data).to.deep.equal(output.asset));
	});

Shopify-api-node/test/fixtures/asset/req/create.json

Lines 1 to 6 in f91e090

	{
	"asset": {
	"key": "assets/empty.gif",
	"attachment": "R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw==\n"
	}
	}

Shopify-api-node/test/fixtures/asset/res/create.json

Lines 1 to 11 in f91e090

	{
	"asset": {
	"key": "assets/empty.gif",
	"public_url": "https://cdn.shopify.com/s/files/1/0006/9093/3842/t/1/assets/empty.gif?16418212202600161583",
	"created_at": "2015-09-02T14:51:55-04:00",
	"updated_at": "2015-09-02T14:51:55-04:00",
	"content_type": "image/gif",
	"size": 43,
	"theme_id": 828155753
	}
	}

In your usage example the second argument of the create() method should only be

const query = { key: 'snippets/test.liquid', value: 'Content' };

[Popesites]

@lpinca

Thanks for quick reply. This worked!

Could you please check req.json:

https://github.com/MONEI/Shopify-api-node/blob/master/test/fixtures/asset/req/create.json

Looks like:

{
  "asset": {
    "key": "assets/empty.gif",
    "attachment": "R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw==\n"
  }
}

I think this syntax is different than what you suggested?

Also that is strange, sorry I thought that on Shopify-api-node/test/asset.test.js that input was equal to res, not req. My bad, but please double check the input data to confirm if that should be updated.

[lpinca]

It's ok. See,

Shopify-api-node/test/asset.test.js

Line 69 in f91e090

.create(828155753, input.asset)

input.asset is

{
  key: 'assets/empty.gif', 
  attachment: 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw==\n' 
}