Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL runas addendum not detected correctly #10

Open
jannepn opened this issue Oct 24, 2017 · 2 comments
Open

SQL runas addendum not detected correctly #10

jannepn opened this issue Oct 24, 2017 · 2 comments

Comments

@jannepn
Copy link
Contributor

jannepn commented Oct 24, 2017

The SQL server runas addendum management pack is not detected as installed.

The reason could be that the name of the management pack is the following:
2005->
Microsoft SQL Server 2016 RunAs Addendum Management Pack
Microsoft.SQLServer.RunAs.2016.Addendum
Microsoft SQL Server 2014 RunAs Addendum Management Pack
Microsoft.SQLServer.RunAs.2014.Addendum
Version 6.7.31.0

And the library:
Microsoft.SQLServer.RunAs.Addendum.Library
Microsoft SQL Server RunAs Addendum Library Management Pack
Has version 6.7.7.2

@shadeon
Copy link
Contributor

shadeon commented Nov 2, 2017

So this could be fixed by altering the system name and folder to Microsoft.SQLServer.RunAs.Addendum.Library. However, this will prevent you from showing the most recent version, as the library MP was the only MP not updated in the most recent update (the rest all share the same version number of 6.7.31.0)

Not sure which is worse (probably incorrect detection, as either way the updating functionality doesn't work) but this is probably a good example of needing to support a multi-pack solution.

Perhaps add a SupportingPacks property to the details.json object, that is an array of Key-value pair objects listing additional packs and their version number that can be used for detection and/or upgrade checking? Haven't checked the UI MP to see how it would handle additional properties that aren't in it's model (so upgrading the catalog doesn't break down level copies of the MP already imported).

@jannepn
Copy link
Contributor Author

jannepn commented Nov 30, 2017

Sounds like a plan with "SupportingPacks". Many managementpacks contain multiple packs and you dont always install them all so that could lead to packs not getting detected correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants