Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query on AVCConfigurationBox #97

Open
bradh opened this issue Mar 9, 2024 · 0 comments
Open

Query on AVCConfigurationBox #97

bradh opened this issue Mar 9, 2024 · 0 comments

Comments

@bradh
Copy link

bradh commented Mar 9, 2024

ISO/IEC 14496-15:2022 Section 5.3.2.1 described the AVC decode configuration record (which appears in the AVCConfigurationBox as well as the corresponding ISO/IEC 23008-12 item property)

My initial implementation overran the box in some of the sample files when parsing items with AVCProfileIndication (aka profile_idc) equal to 100.

The way I read the description and syntax was that there could be additional data, but any extensions to the box would be consistent with previous definitions. So if some new profile (like "High") needed additional fields, those would be conditional and in the syntax.

It looks like at least one of the conformance sample files nalu/mvc/DDF_10s_25fps.mp4 doesn't do that. It has AVCProfileIndication == 100 but none of the fields.

So I've modified my parsing to check there is enough data left. A bit messy because of the external framing, but achieved. Does leave a few questions open though.

Queries:

  1. Is that file considered valid?
  2. When reading, what are the default values for chroma_format, bit_depth_luma_minus8 and bit_depth_chroma_minus8? (I'm assuming SPS NALUs are assumed empty)
  3. When writing out a file that happens to have values equal to those default values, is it preferred to write them out anyway?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant