Possible fix to issue #3 (days tab) #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will apply same fix to weeks and months is days solution is acceptable Slight update to DemoDataGenerator to allow for blank days
|
Thanks for your contribution, looks good at first sight. I will look in more detail tomorrow, I will keep you posted :) |
MPieter
added a commit
that referenced
this pull request
Nov 30, 2014
Possible fix to issue #3 (days tab)
|
I merged the pull request so I could look into some more detail. The code is good! If you are going to implement it for weeks and months also, I think you will have to change the location of the code, I think it is then better to place this in the method |
|
Cool, will have a look at it over the next few days to move code and do the rest of the tabs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix to issue #3 (days tab).
Will apply same fix to weeks and months if days solution is acceptable.
Slight update to DemoDataGenerator to allow for blank days.