Extend observed transitions

[norro]

According to the documentation, the observer is only listening to transition from TRANSITION_STATE_ERRORPROCESSING to PRIMARY_STATE_UNCONFIGURED to set a node status to false. Instead resp. in addition to that we suggest to observe the following transitions and set the status accordingly:

1. Status: true, if

   • goal_state is PRIMARY_STATE_UNCONFIGURED - we consider the node available for metacontrol once it is in its unconfigured state, i.e. it can now be configured and activated

2. Status: false, if

   • goal_state is TRANSITION_STATE_ERRORPROCESSING - once the node enters errorprocessing, it is no longer considered available for metacontrol, unless it enters unconfigured (see 1.)
   • goal_state is PRIMARY_STATE_FINALIZED - once the node enters finalized, because it is offline after this transition

[chcorbato]

Sounds good to me, although right now I do not have a clear view of what this implies. I think this is for @marioney to discuss.

[marioney]

I think the issue is then with the URJC pilot, because the contingency there sends the laser to PRIMARY_STATE_UNCONFIGURED after TRANSITION_STATE_ERRORPROCESSING

@jginesclavero can we send the laser_resender to PRIMARY_STATE_FINALIZED instead? so we have the same configuration in both pilots?

[norro]

Just fyi, this is not time-critical to be fixed.
We have this change implemented for our pilot already.