Skip to content
This repository has been archived by the owner on Jun 23, 2024. It is now read-only.

(temporarily) disable updates for a module #14

Closed
IzzySoft opened this issue Mar 30, 2023 · 0 comments
Closed

(temporarily) disable updates for a module #14

IzzySoft opened this issue Mar 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@IzzySoft
Copy link

IzzySoft commented Mar 30, 2023

I have a module in my collection where the Github repo was (maybe temporarily) set to private (or was removed, I do not know) – see #13). So I would like to (temporarily) disable that module to avoid errors on cli.py sync. Setting upload_to to an empty string leads to

Sync ERROR: unlimited-hotspot: update module failed: AttributeError('NoneType' object has no attribute 'replace')

Maybe some disabled property (defaulting to 0 or false) would be needed? Simply accepting the URL can be empty (for this reason) might work as well, but one might just want to temporarily disable a module for some reason, so a better approach would probably be

  "disable": "<reason why this module should be excluded from modules.json>",
  "disable_updates": "<reason why update checks should be skipped for this module>"

This way

  • the URL can be kept
  • updates can easily be re-enabled
  • one keeps a pointer on the reason to follow up
  • one can easily list disabled modules
@SanmerDev SanmerDev added the enhancement New feature or request label Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants