Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Warning: Illegal reflective access' #26

Closed
jspmccain opened this issue May 1, 2018 · 5 comments
Closed

'Warning: Illegal reflective access' #26

jspmccain opened this issue May 1, 2018 · 5 comments

Comments

@jspmccain
Copy link

Hello,

I'm experiencing the following warning:

image

I'm not really sure how to interpret this? Any advice is appreciated!

Thanks,

Scott

@FarmGeek4Life
Copy link
Collaborator

Let me guess: you're using Java 9 to run MS-GF+? This is a known issue, and there is little I can do about it beyond wait for the maintainers of MS-GF+ dependencies to appropriately update their own dependencies.

This is also why the release notes for Release v2018.01.83 have this line, and a remark on warnings:

Java 9 compatibility: add dependencies on com.sun.xml.bind:jaxb-impl and jaxb:activation to support use with Java 9 (with some warnings). Without this change, users must supply the Java VM argument "--add-modules=java.xml.bind,java.activation"

@jspmccain
Copy link
Author

Yes that's exactly right, I'm using 'openjdk version "9.0.4".

I'm not entirely sure how you'd add those dependencies on com.sun.xml.bind:jaxb-impl and jaxb:activation ? If you have any guidelines or instructions for that they'd be greatly appreciated!

So if those dependencies are not added, I can supply the argument to the main command for using MSGF+?

Thank you!

@FarmGeek4Life
Copy link
Collaborator

Well, the "add dependencies" portion was a change to the code so that you could still run MS-GF+ with Java 9, without needing to add extra text to the command line. The "(with some warnings)" is a reference to the warnings you saw, because there are going to be some changes in those, and so they might be errors with Java 10 instead of just warnings.

@alchemistmatt
Copy link
Collaborator

Just a note, these warnings are still occurring with Java 12

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.sun.xml.bind.v2.runtime.reflect.opt.Injector$1 (file:/C:/DMS_Programs/MSGFDB/MSGFPlus.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int)
WARNING: Please consider reporting this to the maintainers of com.sun.xml.bind.v2.runtime.reflect.opt.Injector$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

We don't have a fix for this, but I'm including these here for reference nonetheless.

@FarmGeek4Life
Copy link
Collaborator

Next release will have a fix for the warning messages (by depending on jaxb-runtime 2.3.1+ instead of jaxb-impl 2.2.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants