Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtExtras sparkline #101

Closed
jthomasmock opened this issue May 18, 2022 · 3 comments · Fixed by #102
Closed

gtExtras sparkline #101

jthomasmock opened this issue May 18, 2022 · 3 comments · Fixed by #102

Comments

@jthomasmock
Copy link

Hi @ddsjoberg - I realize that I forgot to tell you that gtExtras::gt_plt_dist() exists and will likely be the replacement for the more general gt_sparkline() function.

See: https://jthomasmock.github.io/gtExtras/reference/gt_plt_dist.html

Specifically for your use, when I move to CRAN, I'll likely be removing gt_sparkline() in favor of:

  • gt_plt_sparkline() - used only for a literal line graph with variants of how it is presented (add shading below the line, add median line, add mean reference line, or a final value reference line) along with tight control of the line/point/text colors
  • gt_plt_dist() - used for inline distribution plots (boxplot, histogram, rugstrip, density), ie no line chart

To an extent, you should be able to replace gt_sparkline() with gt_plt_dist() but wanted to note the difference, deprecation, and open conversation before I removed the code.

webshot2 is on CRAN now (🚀 ) so I am inching closer to an initial CRAN release of gtEtxras.

@ddsjoberg
Copy link
Collaborator

Thank you for the heads up!

I can go ahead and update my code to use the gt_plt_*() functions now, right?

Once gtExtras is on CRAN, i'll also update the DESCRIPTION file to depend on CRAN instead of GH.

@jthomasmock
Copy link
Author

I can go ahead and update my code to use the gt_plt_*() functions now, right?

Once gtExtras is on CRAN, i'll also update the DESCRIPTION file to depend on CRAN instead of GH.

Yes, the gt_plt_dist() and gt_plt_sparkline() have been around for a bit, I just forgot to give you a heads up!

Let me know if you run into any testing failures from the switch, but they should be drop-in replacements (just splitting out the sparkline "lines" vs inline distributions graph types)

@ddsjoberg ddsjoberg mentioned this issue May 19, 2022
14 tasks
@jthomasmock
Copy link
Author

Thanks! I'm going to go ahead and remove gt_sparkline() from the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants